Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync codegen defaults with compiler defaults and add a ping message so they stay in sync #108616

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Sync codegen defaults with compiler defaults and add a ping message so they stay in sync #108616

merged 1 commit into from
Mar 5, 2023

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Mar 1, 2023 •
edited
Loading

Looks like this got missed in #107241.

@rustbot
Copy link
Collaborator

rustbot commented Mar 1, 2023

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 1, 2023
@albertlarsan68
Copy link
Member

albertlarsan68 commented Mar 2, 2023 •
edited
Loading

Can you change the message to be more precise?
Making the message only appear on compiler.toml modified, that says to sync codegen, and an other one the other way round.

@jyn514
Copy link
Member Author

jyn514 commented Mar 5, 2023

Sure thing, done :)

@albertlarsan68
Copy link
Member

Thanks for the PR!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 5, 2023

📌 Commit ba0b7af has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 5, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2023
@bors
Auto merge of rust-lang#108771 - matthiaskrgr:rollup-whlvo2g, r=matth…
04e9575 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#106440 (Ignore files in .gitignore in tidy)
 - rust-lang#108613 (Remove `llvm.skip-rebuild` option)
 - rust-lang#108616 (Sync codegen defaults with compiler defaults and add a ping message so they stay in sync)
 - rust-lang#108618 (Rename `src/etc/vscode_settings.json` to `rust_analyzer_settings.json`)
 - rust-lang#108626 (rustdoc-json: switch from HashMap to FxHashMap to fix non-determinism)
 - rust-lang#108744 (Don't ICE when encountering bound var in builtin copy/clone bounds)
 - rust-lang#108749 (Clean up rustdoc-js tester.js file)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c86ea5a into rust-lang:master Mar 5, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertlarsan68 albertlarsan68

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jyn514 @rustbot @albertlarsan68 @bors