-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenHarmony targets #108792
Add OpenHarmony targets #108792
Conversation
r? @ehuss (rustbot has picked a reviewer for you, use r? to override) |
These commits modify compiler targets. These commits modify the If this was intentional then you can ignore this comment. Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
I hate to be a pedantic bore about minor points of protocol that mostly don't really matter, but I was cursed at birth with an editor's eyes: Recently, |
r? compiler |
I really don't feel too strongly about it. The C toolchain uses |
Yeah, I don't really care either, my only preference is against name churn. So I just wanted to ask if anyone had doublechecked that, as "C toolchain" might mean "Clang", and I don't know if the same rationales as in #106429 will or will not apply because I'm just another ignorant 外国人 who only heard of OpenHarmony today. |
This comment has been minimized.
This comment has been minimized.
Updated to libc 0.2.140 which has OpenHarmony support. This is now ready for review. The only remaining question is whether to name the targets @tmandry @djkoloski Do you have any thoughts since the same issue came up with fuchsia? |
In our case, we added vendor info to Fuchsia's triples to bring them in line with other triples. Clang actually supports both Right now Rust still has the old set of Fuchsia triples (doubles) as an alias for the new ones (actual triples), but those are on the way out. |
9190662
to
479cdbe
Compare
This comment was marked as resolved.
This comment was marked as resolved.
To add to what @djkoloski said, we consider If rustc also supported dropping vendor info for any target where it's |
I've renamed the OpenHarmony targets to include a @rustbot ready |
r=me after squashing commits. |
- `aarch64-unknown-linux-ohos` - `armv7-unknown-linux-ohos`
@bors r=petrochenkov |
☀️ Test successful - checks-actions |
Finished benchmarking commit (f346fb0): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
aarch64-unknown-linux-ohos
armv7-unknown-linux-ohos
Compiler team MCP: rust-lang/compiler-team#568