Allow binary files to go through the FileLoader
#108797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @lcnr (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
r? compiler |
|
Yeah, this is definitely an incongruency between "read_file" and "read_binary_file". r? @compiler-errors @bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 12, 2023
…le, r=compiler-errors Allow binary files to go through the `FileLoader` I'd like for `include_bytes!` to go through the `FileLoader` in an out-of-tree `rustc_driver` wrapper, and I can't find a reason it's not already done. It seems like most folks providing a custom `FileLoader` would want this too, so I added it. I can solve my problem in other ways if there's a strong reason not to do it, but it seems simple and harmless.
This was referenced Mar 12, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 12, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#108726 (tidy: enforce comment blocks to have an even number of backticks) - rust-lang#108797 (Allow binary files to go through the `FileLoader`) - rust-lang#108841 (Add suggestion to diagnostic when user has array but trait wants slice. (rebased)) - rust-lang#108984 (bootstrap: document tidy) - rust-lang#109013 (Give proper error message when tcx wasn't passed to decoder) - rust-lang#109017 (remove duplicated calls to sort_string) - rust-lang#109018 (Expand on the allocator comment in `rustc-main`) - rust-lang#109028 (Add eslint checks for rustdoc-js tester) - rust-lang#109034 (Commit some tests for the new solver + lazy norm) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like for
include_bytes!to go through theFileLoaderin an out-of-treerustc_driverwrapper, and I can't find a reason it's not already done. It seems like most folks providing a customFileLoaderwould want this too, so I added it.I can solve my problem in other ways if there's a strong reason not to do it, but it seems simple and harmless.