-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump bootstrap compiler to 1.69 beta #108862
Conversation
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
This too? rust/library/core/src/intrinsics.rs Lines 1623 to 1630 in 9b60e6c
There also few in stdarch, but this should be handled separately? |
@bors r+
That doesn't seem to be present in Mark's branch? |
📌 Commit da88c41614fca80f13958b9b1de5c7b7625ed1b9 has been approved by It is now in the queue for this repository. |
stdarch can self-own bumping those, we don't typically touch submodules as part of these bumps. The roundeven functions are likely recently added (in #95317) even though the commit is pretty old, so my guess is they're probably fine to bump next cycle. |
☔ The latest upstream changes (presumably #109001) made this pull request unmergeable. Please resolve the merge conflicts. |
da88c41
to
03411df
Compare
@bors r=pietroalbini |
📌 Commit 03411df4ee9dd185712973e3525b9cc5831be86c has been approved by It is now in the queue for this repository. |
⌛ Testing commit 03411df4ee9dd185712973e3525b9cc5831be86c with merge 5a6f19749c02d4456145ebf61ab920ff52c21493... |
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
This removes a dependency on ntapi 0.3.x which failed to compiled with latest beta. rust-lang/rustc-perf@93dc60d removed that dependency in the upstream rustc-perf.
@bors r=pietroalbini |
@bors rollup=never |
⌛ Testing commit df0be2d with merge 424f5bc5457b181035a19f85879474cf95103c30... |
💔 Test failed - checks-actions |
The job Click to see the possible cause of the failure (guessed by this bot)
|
@bors retry I doubt this is spurious, but feels likely to be very annoying to track down so want to get another datapoint. |
⌛ Testing commit df0be2d with merge 500e03b505ad296cccbd1180ff2f4bd26e6e4aea... |
|
💥 Test timed out |
@bors retry |
☀️ Test successful - checks-actions |
Finished benchmarking commit (13afbda): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
r? @pietroalbini