Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: evaluate with wrong obligation stack #108901

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Conversation

LYF1999
Copy link
Contributor

@LYF1999 LYF1999 commented Mar 8, 2023

fix #108897
r? @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 8, 2023
@lcnr
Copy link
Contributor

lcnr commented Mar 8, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Mar 8, 2023

📌 Commit 204ba32 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2023
@lcnr
Copy link
Contributor

lcnr commented Mar 8, 2023

@bors rollup=always

@lcnr lcnr added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 8, 2023
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 8, 2023
fix: evaluate with wrong obligation stack

fix rust-lang#108897
r? `@lcnr`
@LYF1999 LYF1999 mentioned this pull request Mar 8, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 8, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#108686 (rustdoc: include link on all.html location header)
 - rust-lang#108846 (StableMIR: Proof-of-concept implementation + test )
 - rust-lang#108873 (Simplify `sort_by` calls)
 - rust-lang#108883 (Suppress copy impl error when post-normalized type references errors)
 - rust-lang#108884 (Tweak illegal `Copy` impl message)
 - rust-lang#108887 (Rename `MapInPlace` as `FlatMapInPlace`.)
 - rust-lang#108901 (fix: evaluate with wrong obligation stack)
 - rust-lang#108903 (Move Clippy tests back to their intended directory)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 33c3036 into rust-lang:master Mar 9, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 9, 2023
@LYF1999 LYF1999 deleted the yf/108897 branch March 9, 2023 02:46
@pnkfelix pnkfelix added the stable-nominated Nominated for backporting to the compiler in the stable channel. label Mar 9, 2023
@apiraino
Copy link
Contributor

apiraino commented Mar 9, 2023

Beta backport accepted as per compiler team on Zulip

Stable backport declined since 1.68 is not affected

@rustbot label +beta-accepted -stable-nominated

@rustbot rustbot added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed stable-nominated Nominated for backporting to the compiler in the stable channel. labels Mar 9, 2023
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 11, 2023
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.70.0, 1.69.0 Mar 11, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 17, 2023
…k-Simulacrum

[beta] backport

This PR backports:

- rust-lang#108901: fix: evaluate with wrong obligation stack
- rust-lang#108754: Retry `pred_known_to_hold_modulo_regions` with fulfillment if ambiguous
- rust-lang#108691: fix multiple issues when promoting type-test subject

It also bumps to the released stable.

r? `@Mark-Simulacrum`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected build pass with a not Send future
7 participants