Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panic_immediate_abort requires abort as a panic strategy #108924

Merged
merged 1 commit into from
Mar 24, 2023
Merged

panic_immediate_abort requires abort as a panic strategy #108924

merged 1 commit into from
Mar 24, 2023

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Mar 8, 2023

Guide panic_immediate_abort users away from -Cpanic=unwind and towards -Cpanic=abort to avoid an accidental use of the feature with the unwind strategy, e.g., on a targets where unwind is the default.

The -Cpanic=unwind combination doesn't offer the same benefits, since the code would still be generated under the assumption that functions implemented in Rust can unwind.

@rustbot
Copy link
Collaborator

rustbot commented Mar 8, 2023

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 8, 2023
@rustbot
Copy link
Collaborator

rustbot commented Mar 8, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@tmiasko
panic_immediate_abort requires abort as a panic strategy
7c75e39 
Guide `panic_immediate_abort` users away from `-Cpanic=unwind` and
towards `-Cpanic=abort` to avoid an accidental use of the feature with
the unwind strategy, e.g., on a targets where unwind is the default.

The `-Cpanic=unwind` combination doesn't offer the same benefits, since
the code would still be generated under the assumption that functions
implemented in Rust can unwind.
@tmiasko tmiasko force-pushed the panic-immediate-abort branch from 833edf4 to 7c75e39 Compare March 8, 2023 21:32
@tmiasko tmiasko mentioned this pull request Mar 9, 2023
Closed
@thomcc
Copy link
Member

thomcc commented Mar 22, 2023

The -Cpanic=unwind combination doesn't offer the same benefits, since the code would still be generated under the assumption that functions implemented in Rust can unwind.

While this is true, I'm not sure that warrants sealing it off entirely? I guess I don't know why you'd want panic=unwind+panic_immediate_abort, but it's not like it's inherently nonsensical...

@tmiasko
Copy link
Contributor Author

tmiasko commented Mar 22, 2023 •
edited
Loading

I don't see any use case for panic=unwind+panic_immediate_abort either. Given that this configuration is broken since #104999 (for reasons described in #107016), I would use this as an opportunity to disable it entirely to avoid accidental misuse. If an actual use-case arises later, we can always revert.

@thomcc
Copy link
Member

thomcc commented Mar 23, 2023

Hm, is it currently broken?

@tmiasko
Copy link
Contributor Author

tmiasko commented Mar 23, 2023

Yes, the panic=unwind+panic_immediate_abort combination is broken right now.

@thomcc
Copy link
Member

thomcc commented Mar 23, 2023

Hm, okay. This seems fine as it gives a better error message, then.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 23, 2023

📌 Commit 7c75e39 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 24, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 24, 2023
@bors
Auto merge of rust-lang#109547 - matthiaskrgr:rollup-zczqgdk, r=matth…
4c0f500 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#108629 (rustdoc: add support for type filters in arguments and generics)
 - rust-lang#108924 (panic_immediate_abort requires abort as a panic strategy)
 - rust-lang#108961 (Refine error spans for const args in hir typeck)
 - rust-lang#108986 (sync LVI tests)
 - rust-lang#109142 (Add block-based mutex unlocking example)
 - rust-lang#109368 (fix typo in the creation of OpenOption for RustyHermit)
 - rust-lang#109493 (Return nested obligations from canonical response var unification)
 - rust-lang#109515 (Add AixLinker to support linking on AIX)
 - rust-lang#109536 (resolve: Rename some cstore methods to match queries and add comments)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d9c05b8 into rust-lang:master Mar 24, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 24, 2023
@tmiasko tmiasko deleted the panic-immediate-abort branch March 24, 2023 09:31
@wcampbell0x2a wcampbell0x2a mentioned this pull request Apr 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tmiasko @rustbot @thomcc @bors