Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback part of pr 104137 that broke wasm linker overriding #108996

Merged
merged 4 commits into from
Mar 29, 2023
Merged

Rollback part of pr 104137 that broke wasm linker overriding #108996

merged 4 commits into from
Mar 29, 2023

Commits on Mar 14, 2023

  1. the fix 

    (fixed build by adding missing import.)
    @pnkfelix
    pnkfelix committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    e919f0f View commit details
    Browse the repository at this point in the history

  2. Test using pattern established in run-make/wasm-stringify-ints-small. 

    Replicates problem on my machine.

To exercise the test, I had to use a config.toml that has:

```
[build]
target = ["x86_64-unknown-linux-gnu","wasm32-unknown-unknown"]
nodejs = "node"

[rust]
lld = true
```
    @pnkfelix
    pnkfelix committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    568b722 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Delete Makefile 

    removing regression test
    @pnkfelix
    pnkfelix authored Mar 29, 2023
    Configuration menu
    Copy the full SHA
    cda130f View commit details
    Browse the repository at this point in the history

  2. Delete foo.rs 

    removing regression test
    @pnkfelix
    pnkfelix authored Mar 29, 2023
    Configuration menu
    Copy the full SHA
    167623a View commit details
    Browse the repository at this point in the history