resolve: Querify most cstore access methods (subset 2) #109137

petrochenkov · 2023-03-14T19:18:58Z

These changes are less likely to cause perf regressions than the rest of #108346.

rustbot · 2023-03-14T19:19:04Z

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

petrochenkov · 2023-03-14T19:19:36Z

@bors try @rust-timer queue

bors · 2023-03-14T19:19:44Z

⌛ Trying commit 43d8ec8ec43fe9c72cbd697e329697684d9fdb19 with merge 53bf1c7b4c5e88f6f206f2d4a2bdc4bc4ce59a3d...

bors · 2023-03-14T22:02:52Z

☀️ Try build successful - checks-actions
Build commit: 53bf1c7b4c5e88f6f206f2d4a2bdc4bc4ce59a3d (53bf1c7b4c5e88f6f206f2d4a2bdc4bc4ce59a3d)

rust-timer · 2023-03-15T04:56:10Z

Finished benchmarking commit (53bf1c7b4c5e88f6f206f2d4a2bdc4bc4ce59a3d): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.4%, 2.8%]	11
Regressions ❌ (secondary)	1.5%	[0.9%, 2.8%]	20
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.3%]	2
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.3%]	5
All ❌✅ (primary)	0.9%	[-0.3%, 2.8%]	13

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.8%, 0.8%]	1
Regressions ❌ (secondary)	3.0%	[1.1%, 5.2%]	13
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-3.1%, -2.3%]	2
All ❌✅ (primary)	0.8%	[0.8%, 0.8%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.5%	[1.0%, 3.4%]	4
Regressions ❌ (secondary)	2.4%	[1.0%, 3.6%]	13
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.6%	[-5.3%, -3.8%]	4
All ❌✅ (primary)	2.5%	[1.0%, 3.4%]	4

compiler/rustc_resolve/src/build_reduced_graph.rs

petrochenkov · 2023-03-15T06:52:09Z

@bors try @rust-timer queue

bors · 2023-03-15T06:52:17Z

⌛ Trying commit e41524a3381910d4773b4dc07215eaaa4c94fb4d with merge 59b2f1c803e86cd7212fd597afdda30a83916a35...

bors · 2023-03-15T09:36:33Z

☀️ Try build successful - checks-actions
Build commit: 59b2f1c803e86cd7212fd597afdda30a83916a35 (59b2f1c803e86cd7212fd597afdda30a83916a35)

rust-timer · 2023-03-15T11:26:06Z

Finished benchmarking commit (59b2f1c803e86cd7212fd597afdda30a83916a35): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.3%, 1.5%]	11
Regressions ❌ (secondary)	0.9%	[0.4%, 1.7%]	9
Improvements ✅ (primary)	-0.3%	[-0.4%, -0.2%]	4
Improvements ✅ (secondary)	-0.9%	[-0.9%, -0.9%]	1
All ❌✅ (primary)	0.5%	[-0.4%, 1.5%]	15

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.1%	[3.1%, 3.1%]	1
Regressions ❌ (secondary)	2.7%	[1.6%, 4.5%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-3.0%, -0.9%]	2
All ❌✅ (primary)	3.1%	[3.1%, 3.1%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

bors · 2023-03-16T13:54:14Z

⌛ Trying commit 18b59f5 with merge 4b87593316598345c17e9ace90d052f5e3551452...

bors · 2023-03-16T16:17:38Z

☀️ Try build successful - checks-actions
Build commit: 4b87593316598345c17e9ace90d052f5e3551452 (4b87593316598345c17e9ace90d052f5e3551452)

rust-timer · 2023-03-18T00:28:02Z

Finished benchmarking commit (4b87593316598345c17e9ace90d052f5e3551452): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.5%, -0.2%]	6
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-0.5%, -0.2%]	6

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.4%	[0.5%, 2.8%]	3
Regressions ❌ (secondary)	2.5%	[2.3%, 3.1%]	4
Improvements ✅ (primary)	-0.6%	[-0.8%, -0.5%]	2
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	0.6%	[-0.8%, 2.8%]	5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-0.8%, -0.7%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.7%	[-0.8%, -0.7%]	2

cjgillot · 2023-03-18T10:11:51Z

r=me in this form.
(Except if you want to make additional changes before landing it.)

petrochenkov · 2023-03-18T10:23:25Z

r? @cjgillot
@bors r=cjgillot

bors · 2023-03-18T10:23:27Z

📌 Commit 18b59f5 has been approved by cjgillot

It is now in the queue for this repository.

petrochenkov · 2023-03-18T10:24:01Z

@bors rollup=maybe

resolve: Querify most cstore access methods (subset 2) These changes are less likely to cause perf regressions than the rest of rust-lang#108346.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#108541 (Suppress `opaque_hidden_inferred_bound` for nested RPITs) - rust-lang#109137 (resolve: Querify most cstore access methods (subset 2)) - rust-lang#109380 (add `known-bug` test for unsoundness issue) - rust-lang#109462 (Make alias-eq have a relation direction (and rename it to alias-relate)) - rust-lang#109475 (Simpler checked shifts in MIR building) - rust-lang#109504 (Stabilize `arc_into_inner` and `rc_into_inner`.) - rust-lang#109506 (make param bound vars visibly bound vars with -Zverbose) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned davidtwco Mar 14, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 14, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 14, 2023

petrochenkov mentioned this pull request Mar 14, 2023

resolve: Querify most cstore access methods #108346

Closed

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 15, 2023

petrochenkov commented Mar 15, 2023

View reviewed changes

compiler/rustc_resolve/src/build_reduced_graph.rs Outdated Show resolved Hide resolved

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2023

petrochenkov force-pushed the qcstore2 branch from 43d8ec8 to e41524a Compare March 15, 2023 06:51

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 15, 2023

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 15, 2023

petrochenkov added 2 commits March 16, 2023 17:22

resolve: Remove item_generics_num_lifetimes

f28f77f

resolve: Remove item_attrs_untracked

d99e01f

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 16, 2023

This comment has been minimized.

Sign in to view

rustbot removed S-waiting-on-perf Status: Waiting on a perf run to be completed. perf-regression Performance regression. labels Mar 18, 2023

rustbot assigned cjgillot and unassigned davidtwco Mar 18, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 18, 2023

matthiaskrgr mentioned this pull request Mar 20, 2023

Rollup of 7 pull requests #109383

Closed

matthiaskrgr mentioned this pull request Mar 23, 2023

Rollup of 9 pull requests #109513

Closed

This was referenced Mar 23, 2023

Rollup of 8 pull requests #109516

Closed

Rollup of 7 pull requests #109517

Merged

bors merged commit 3e33fb9 into rust-lang:master Mar 23, 2023

rustbot added this to the 1.70.0 milestone Mar 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

resolve: Querify most cstore access methods (subset 2) #109137

resolve: Querify most cstore access methods (subset 2) #109137

petrochenkov commented Mar 14, 2023

rustbot commented Mar 14, 2023

petrochenkov commented Mar 14, 2023

This comment has been minimized.

bors commented Mar 14, 2023

bors commented Mar 14, 2023

This comment has been minimized.

rust-timer commented Mar 15, 2023

petrochenkov commented Mar 15, 2023

This comment has been minimized.

bors commented Mar 15, 2023

bors commented Mar 15, 2023

This comment has been minimized.

rust-timer commented Mar 15, 2023

bors commented Mar 16, 2023

bors commented Mar 16, 2023

This comment has been minimized.

rust-timer commented Mar 18, 2023

cjgillot commented Mar 18, 2023

petrochenkov commented Mar 18, 2023

bors commented Mar 18, 2023

petrochenkov commented Mar 18, 2023

resolve: Querify most cstore access methods (subset 2) #109137

resolve: Querify most cstore access methods (subset 2) #109137

Conversation

petrochenkov commented Mar 14, 2023

rustbot commented Mar 14, 2023

petrochenkov commented Mar 14, 2023

This comment has been minimized.

bors commented Mar 14, 2023

bors commented Mar 14, 2023

This comment has been minimized.

rust-timer commented Mar 15, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

petrochenkov commented Mar 15, 2023

This comment has been minimized.

bors commented Mar 15, 2023

bors commented Mar 15, 2023

This comment has been minimized.

rust-timer commented Mar 15, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

bors commented Mar 16, 2023

bors commented Mar 16, 2023

This comment has been minimized.

rust-timer commented Mar 18, 2023

Overall result: ✅ improvements - no action needed

cjgillot commented Mar 18, 2023

petrochenkov commented Mar 18, 2023

bors commented Mar 18, 2023

petrochenkov commented Mar 18, 2023