Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mv tests/codegen/issue-* tests/codegen/issues/ #109172

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

scottmcm
Copy link
Member

No changes to the contents; just a move.

Like how there's a https://github.com/rust-lang/rust/tree/master/tests/ui/issues folder.

@rustbot
Copy link
Collaborator

rustbot commented Mar 15, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 15, 2023
@WaffleLapkin
Copy link
Member

r? @WaffleLapkin
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 15, 2023

📌 Commit 6e1ab1d has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 15, 2023
…, r=WaffleLapkin

mv tests/codegen/issue-* tests/codegen/issues/

No changes to the contents; just a move.

Like how there's a <https://github.com/rust-lang/rust/tree/master/tests/ui/issues> folder.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 16, 2023
…, r=WaffleLapkin

mv tests/codegen/issue-* tests/codegen/issues/

No changes to the contents; just a move.

Like how there's a <https://github.com/rust-lang/rust/tree/master/tests/ui/issues> folder.
@matthiaskrgr
Copy link
Member

failed in #109205
@bors r- rollup=never

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 16, 2023
@w-flo
Copy link

w-flo commented Mar 16, 2023

static_dllimport_aux.rs probably needs to move from tests/codegen/auxiliary to test/codegen/issues/auxiliary, too.

@WaffleLapkin
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 17, 2023

📌 Commit 053cde3db3cb379aa17a678421980356a015cb4a has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 17, 2023
@bors
Copy link
Contributor

bors commented Mar 18, 2023

⌛ Testing commit 053cde3db3cb379aa17a678421980356a015cb4a with merge 05a655fd1e3611a50bb35e532f0fe1e148140e04...

@bors
Copy link
Contributor

bors commented Mar 18, 2023

💔 Test failed - checks-actions

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 18, 2023
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 18, 2023
@ehuss
Copy link
Contributor

ehuss commented Mar 18, 2023

@bors retry
wasm32 SIGSEGV

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2023
@rust-log-analyzer

This comment has been minimized.

@WaffleLapkin
Copy link
Member

I think this is the LLVM update failure? LLVM update was reverted in #109326, so I guess a rebase should fix CI.

@WaffleLapkin WaffleLapkin force-pushed the move-codegen-issues-tests branch from 053cde3 to 48011e2 Compare March 20, 2023 10:55
@WaffleLapkin
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 21, 2023

📌 Commit 48011e2 has been approved by WaffleLapkin

It is now in the queue for this repository.

@Noratrieb
Copy link
Member

@bors rollup=iffy
the queue is really full

@bors
Copy link
Contributor

bors commented Mar 23, 2023

⌛ Testing commit 48011e2 with merge cf81181...

@bors
Copy link
Contributor

bors commented Mar 23, 2023

☀️ Test successful - checks-actions
Approved by: WaffleLapkin
Pushing cf81181 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 23, 2023
@bors bors merged commit cf81181 into rust-lang:master Mar 23, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 23, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (cf81181): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.6% [-0.7%, -0.6%] 4
Improvements ✅
(secondary)
-0.5% [-0.6%, -0.4%] 2
All ❌✅ (primary) -0.6% [-0.7%, -0.6%] 4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.1% [0.4%, 1.6%] 5
Improvements ✅
(primary)
-3.0% [-3.0%, -3.0%] 1
Improvements ✅
(secondary)
-1.7% [-2.8%, -0.4%] 12
All ❌✅ (primary) -3.0% [-3.0%, -3.0%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.5% [-0.6%, -0.4%] 6
All ❌✅ (primary) - - 0

@scottmcm scottmcm deleted the move-codegen-issues-tests branch March 24, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.