Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unequal → Not equal #109180

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Unequal → Not equal #109180

merged 1 commit into from
Mar 16, 2023

Conversation

gimbling-away
Copy link
Contributor

Fixes #109168

@rustbot
Copy link
Collaborator

rustbot commented Mar 15, 2023

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 15, 2023
@rustbot
Copy link
Collaborator

rustbot commented Mar 15, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras

Some changes occurred in src/tools/rust-analyzer

cc @rust-lang/rust-analyzer

@compiler-errors
Copy link
Member

please squash this into one commit, then i can approve

@gimbling-away
Copy link
Contributor Author

(Sorry for the ping spam MIR & RA peeps, just a bunch of comment changes 😅)

@compiler-errors
Copy link
Member

Also, actually, the guidance is typically to leave tools alone. Can you revert that rust-analyzer change?

@gimbling-away
Copy link
Contributor Author

Done & Squashed 👏🏻

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 15, 2023

📌 Commit e5a5b90 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 15, 2023
@matthiaskrgr
Rollup merge of rust-lang#109180 - gimbles:master, r=compiler-errors
6e76106 
Unequal → Not equal

Fixes rust-lang#109168
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 15, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 16, 2023
@matthiaskrgr
Rollup merge of rust-lang#109180 - gimbles:master, r=compiler-errors
384733f 
Unequal → Not equal

Fixes rust-lang#109168
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 16, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 16, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 16, 2023
@bors
Auto merge of rust-lang#109206 - matthiaskrgr:rollup-oev8ax6, r=matth…
7ac4b82 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#108875 (rustdoc: fix type search for `Option` combinators)
 - rust-lang#108971 (error-msg: impl better suggestion for `E0532`)
 - rust-lang#109139 (rustdoc: DocFS: Replace rayon with threadpool and enable it for all targets)
 - rust-lang#109151 (Assert def-kind is correct for alias types)
 - rust-lang#109158 (error-msg: expand suggestion for `unused_def` lint)
 - rust-lang#109166 (make `define_opaque_types` fully explicit)
 - rust-lang#109171 (Some cleanups in our normalization logic)
 - rust-lang#109180 (Unequal → Not equal)
 - rust-lang#109185 (rustdoc: remove `std::` from primitive intra-doc link tooltips)
 - rust-lang#109192 (Mention UEFI target promotion in release notes for 1.67.0)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7696248 into rust-lang:master Mar 16, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.

[docs] Iterator fuction ne description should use "not equal"
4 participants
@gimbling-away @rustbot @compiler-errors @bors