Use size_of_val instead of manual calculation
#109287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @thomcc (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment was marked as resolved.
This comment was marked as resolved.
Very minor thing that I happened to notice in passing, but it's both shorter and means it gets `mul nuw`, so why not.
scottmcm
force-pushed
the
hash-slice-size-of-val
branch
from
7693e92 to
3508879
Compare
scottmcm
commented
Mar 18, 2023
| @@ -46,7 +46,7 @@ pub fn size_and_align_of_dst<'a, 'tcx, Bx: BuilderMethods<'a, 'tcx>>( | |||
| // NOTE: ideally, we want the effects of both `unchecked_smul` and `unchecked_umul` | |||
| // (resulting in `mul nsw nuw` in LLVM IR), since we know that the multiplication | |||
| // cannot signed wrap, and that both operands are non-negative. But at the time of writing, | |||
| // `BuilderMethods` can't do this, and it doesn't seem to enable any further optimizations. | |||
| // the `LLVM-C` binding can't do this, and it doesn't seem to enable any further optimizations. | |||
There was a problem hiding this comment.
Just to keep someone else from going "well adding it to our trait sounds easy" -- the actual hard part is adding it to
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#107416 (Error code E0794 for late-bound lifetime parameter error.) - rust-lang#108772 (Speed up tidy quite a lot) - rust-lang#109193 (Add revisions for -Zlower-impl-trait-in-trait-to-assoc-ty fixed tests) - rust-lang#109234 (Tweak implementation of overflow checking assertions) - rust-lang#109238 (Fix generics mismatch errors for RPITITs on -Zlower-impl-trait-in-trait-to-assoc-ty) - rust-lang#109283 (rustdoc: reduce allocations in `visibility_to_src_with_space`) - rust-lang#109287 (Use `size_of_val` instead of manual calculation) - rust-lang#109288 (Stabilise `unix_socket_abstract`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very minor thing that I happened to notice in passing, but it's both shorter and means it gets
mul nsw, so why not.