Use llvm 16.0.0 instead of 16.0.0-rc4 for build-clang.sh

[raphamorim]

Ref: #107224

This PR doesn't make any update on LLVM submodule used by Rust repo, but would be super keen to update it, if necessary (https://rustc-dev-guide.rust-lang.org/backend/updating-llvm.html). LLVM 16.0.0 has been released on March 18, while Rust 1.70 will become stable on June 1.

• https://releases.llvm.org/16.0.0/docs/ReleaseNotes.html

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[cuviper]

r? cuviper
@bors r+ rollup=never

Note that the submodule was reverted to 15 in #109326, but 16 is coming back in #109474.

[bors]

📌 Commit d13b423 has been approved by cuviper

It is now in the queue for this repository.

[cuviper]

Also, there's no significant difference between 16.0.0-rc4 and 16.0.0 -- only a couple doc fixes. It's still fine for us to update so folks don't wonder about using an rc, but don't expect any perf or bug fixes here.

[raphamorim]

Also, there's no significant difference between 16.0.0-rc4 and 16.0.0 -- only a couple doc fixes. It's still fine for us to update so folks don't wonder about using an rc, but don't expect any perf or bug fixes here.

Yup there's no really significant difference between 16.0.0-rc4 and 16.0.0 But good to lock a definitive release instead of release candidate at least for the clang build.

Note that the submodule was reverted to 15 in #109326, but 16 is coming back in #109474.

Hmm Haven't see that PR, maybe better to let that PR lead the llvm change instead and this one only apply the clang-build.sh change.

[bors]

⌛ Testing commit d13b423 with merge f3d5bd22b3fe408843a37f94e60a0f40785c3c9d...

[bors]

💔 Test failed - checks-actions

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Step 3/25 : RUN yum upgrade -y &&     yum install -y epel-release &&     yum install -y       automake       bzip2       file       cmake3       gcc       gcc-c++       git       glibc-devel.i686       glibc-devel.x86_64       libedit-devel       libstdc++-devel.i686       libstdc++-devel.x86_64       make       ncurses-devel       openssl-devel       patch       perl       pkgconfig       python3       unzip       wget       xz       zlib-devel.i686       zlib-devel.x86_64       && yum clean all
 ---> Running in db9feecc006e
Loaded plugins: fastestmirror, ovl
Determining fastest mirrors
 * base: ziply.mm.fcix.net
 * extras: mirrors.vcea.wsu.edu
 * updates: ftp.osuosl.org
--> Running transaction check
---> Package bash.x86_64 0:4.2.46-34.el7 will be updated
---> Package bash.x86_64 0:4.2.46-35.el7_9 will be an update
---> Package bind-license.noarch 32:9.11.4-26.P2.el7 will be updated
---

Complete!
Loaded plugins: fastestmirror, ovl
Loading mirror speeds from cached hostfile
 * base: ziply.mm.fcix.net
 * extras: mirrors.vcea.wsu.edu
 * updates: ftp.osuosl.org
--> Running transaction check
---> Package epel-release.noarch 0:7-11 will be installed
--> Finished Dependency Resolution

---

Complete!
Loaded plugins: fastestmirror, ovl
Loading mirror speeds from cached hostfile
 * base: ziply.mm.fcix.net
 * epel: d2lzkl7pfhq30w.cloudfront.net
 * extras: mirrors.vcea.wsu.edu
 * updates: ftp.osuosl.org
Trying other mirror.
Package 1:pkgconfig-0.27.1-4.el7.x86_64 already installed and latest version
Package xz-5.2.2-2.el7_9.x86_64 already installed and latest version
Resolving Dependencies
---
  0     0    0     0    0     0      0      0 --:--:--  0:00:05 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:06 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:07 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:08 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:09 --:--:--     0curl: (6) Could not resolve host: ftp.gnu.org; Unknown error
xzcat: (stdin): File format not recognized
tar: This does not look like a tar archive
The command '/bin/sh -c ./build-gcc.sh && yum remove -y gcc gcc-c++' returned a non-zero code: 2
Command failed. Attempt 2/5:
Sending build context to Docker daemon  687.1kB

---
  0     0    0     0    0     0      0      0 --:--:--  0:00:05 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:06 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:07 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:08 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:09 --:--:--     0curl: (6) Could not resolve host: ftp.gnu.org; Unknown error
xzcat: (stdin): File format not recognized
tar: This does not look like a tar archive
The command '/bin/sh -c ./build-gcc.sh && yum remove -y gcc gcc-c++' returned a non-zero code: 2
Command failed. Attempt 3/5:
Sending build context to Docker daemon  687.1kB

---
  0     0    0     0    0     0      0      0 --:--:--  0:00:05 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:06 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:07 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:08 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:09 --:--:--     0curl: (6) Could not resolve host: ftp.gnu.org; Unknown error
xzcat: (stdin): File format not recognized
tar: This does not look like a tar archive
The command '/bin/sh -c ./build-gcc.sh && yum remove -y gcc gcc-c++' returned a non-zero code: 2
Command failed. Attempt 4/5:
Sending build context to Docker daemon  687.1kB

---
  0     0    0     0    0     0      0      0 --:--:--  0:00:05 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:06 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:07 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:08 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:09 --:--:--     0curl: (6) Could not resolve host: ftp.gnu.org; Unknown error
xzcat: (stdin): File format not recognized
tar: This does not look like a tar archive
The command '/bin/sh -c ./build-gcc.sh && yum remove -y gcc gcc-c++' returned a non-zero code: 2
Command failed. Attempt 5/5:
Sending build context to Docker daemon  687.1kB

---
  0     0    0     0    0     0      0      0 --:--:--  0:00:05 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:06 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:07 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:08 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:09 --:--:--     0curl: (6) Could not resolve host: ftp.gnu.org; Unknown error
xzcat: (stdin): File format not recognized
tar: This does not look like a tar archive
The command '/bin/sh -c ./build-gcc.sh && yum remove -y gcc gcc-c++' returned a non-zero code: 2
The command has failed after 5 attempts.
##[error]Process completed with exit code 1.
Post job cleanup.

[cuviper]

@bors retry

[bors]

⌛ Testing commit d13b423 with merge 5ce70ed...

[bors]

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 5ce70ed to master...

[rust-timer]

Finished benchmarking commit (5ce70ed): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.6%, 0.6%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.6%, 0.6%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[2.5%, 2.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.