Avoid unwrap in Parser::is_lit_bad_ident #110022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
I'm not sure if I've commented on one of your PRs with this before, but I find myself saying it a lot on github in general, but it's typically more useful to give a PR a title that describes what it does functionally, e.g. "Avoid unwrap in Parser::is_lit_bad_ident when literal doesn't have suffix" is more useful for history than "fix ###". The "fix ###" part is already in the description of the PR anyways, so it doesn't also need to be the title title. |
|
Don't think I've ever been told that before. It's one of the things which you just don't know until someone tells you (rustc-dev-guide doesn't really give that advice, etc) so thank you. I'll improve them in the future :) |
Noratrieb
changed the title
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 7, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#109806 (Workaround rust-lang#109797 on windows-gnu) - rust-lang#109957 (diagnostics: account for self type when looking for source of unsolved type variable) - rust-lang#109960 (Fix buffer overrun in bootstrap and (test-only) symlink_junction) - rust-lang#110013 (Label `non_exhaustive` attribute on privacy errors from non-local items) - rust-lang#110016 (Run collapsed GUI test in mobile mode as well) - rust-lang#110022 (fix: fix regression in rust-lang#109203) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110014
r? @compiler-errors