Enable colored output on Windows #11020
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| None => { | ||
| let number = if bg { color + 10 } else { color }; | ||
| let ansi = if number < 8 { | ||
| format!("\x1b[{}m", 30 + number) |
There was a problem hiding this comment.
Do we really want to be hard-coding colour escapes? Doesn't this code path get taken whenever rustc is connected to a tty, even if we don't know how it handles colours?
There was a problem hiding this comment.
AFAIK there's no other way since msys doesn't tell you the escape codes.
Regarding the second question see my comment above.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 2, 2023
New lint [`tuple_array_conversions`] Closes rust-lang#10748 PS, the implementation is a bit ugly 😅 ~~I will likely refactor soon enough :)~~ Done :D changelog: New lint [`tuple_array_conversions`]
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 11, 2024
…tic, r=Veykril feat: Add diagnostic with fix to replace trailing `return <val>;` with `<val>` Works for functions and closures. Ignores desugared return expressions (e.g. from desugared try operators). Fixes: rust-lang#10970 Completes: rust-lang#11020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables 16 color terminal support if
terminfoisn't supported and one of the following conditions is met:libc::isattyreturns something >0 (e.g. cmd.exe).Fixes #2807 except for attributes other than ForegroundColor and BackgroundColor.