-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skip implied bounds if unconstrained lifetime exists #110272
Merged
bors
merged 3 commits into
rust-lang:master
from
Ezrashaw:fix-unconned-lt-in-implbounds
Apr 16, 2023
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
// ICE regression relating to unconstrained lifetimes in implied | ||
// bounds. See #110161. | ||
|
||
// compile-flags: --crate-type=lib | ||
|
||
trait LtTrait { | ||
type Ty; | ||
} | ||
|
||
// erroneous `Ty` impl | ||
impl LtTrait for () { | ||
//~^ ERROR not all trait items implemented, missing: `Ty` [E0046] | ||
} | ||
|
||
// `'lt` is not constrained by the erroneous `Ty` | ||
impl<'lt, T> LtTrait for Box<T> | ||
where | ||
T: LtTrait<Ty = &'lt ()>, | ||
{ | ||
type Ty = &'lt (); | ||
} | ||
|
||
// unconstrained lifetime appears in implied bounds | ||
fn test(_: <Box<()> as LtTrait>::Ty) {} | ||
|
||
fn test2<'x>(_: &'x <Box<()> as LtTrait>::Ty) {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
error[E0046]: not all trait items implemented, missing: `Ty` | ||
--> $DIR/issue-110161.rs:11:1 | ||
| | ||
LL | type Ty; | ||
| ------- `Ty` from trait | ||
... | ||
LL | impl LtTrait for () { | ||
| ^^^^^^^^^^^^^^^^^^^ missing `Ty` in implementation | ||
|
||
error: aborting due to previous error | ||
|
||
For more information about this error, try `rustc --explain E0046`. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep the assertion around for
has_non_lifetime_infer
and only delay a span bug if we have infer lifetimes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess type vars has the same problem. For a test case, we can probably replace
&'lt ()
by(X,)
in the ui test. I'm not sure though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw (and I'm completely inexperienced), I think we are good here, there aren't unconstrained type variables in the same way?