Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make various trait impls/methods const for the Alignment and NonZero* structs. #110346

Closed
wants to merge 1 commit into from
Closed

Make various trait impls/methods const for the Alignment and NonZero* structs. #110346

wants to merge 1 commit into from

Conversation

JohnBobbo96
Copy link
Contributor

Make a few more methods and trait implementations const for the Alignment struct, as well as the NonZero* types.

@rustbot
Copy link
Collaborator

rustbot commented Apr 15, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 15, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 15, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

kadiwa4
kadiwa4 reviewed Apr 15, 2023
View reviewed changes
library/core/src/ptr/alignment.rs Outdated
@@ -18,7 +18,8 @@ pub struct Alignment(AlignmentEnum);
const _: () = assert!(mem::size_of::<Alignment>() == mem::size_of::<usize>());
const _: () = assert!(mem::align_of::<Alignment>() == mem::align_of::<usize>());

fn _alignment_can_be_structurally_matched(a: Alignment) -> bool {
#[inline]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why #[inline]? Does this function even get called anywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick search and it doesn't seem to be used, so i have removed it for now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove the entire function. It tests that Alignment can be structurally matched, and if it can't, a compiler error is raised.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did not realize that, i have added it back.

@JohnBobbo96
Make various trait impls/methods const for
709bb2d 
the `Alignment` and `NonZero`* structs.
@fee1-dead
Copy link
Member

Thanks for the PR, but I don't think we are accepting new PRs adding new ~const functionality to libcore at the moment.

@JohnBobbo96
Copy link
Contributor Author

Alright, i will close this PR.

@fee1-dead
Copy link
Member

It can be reopened once #110395 is carried out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadiwa4 kadiwa4 kadiwa4 left review comments

Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JohnBobbo96 @rustbot @fee1-dead @kadiwa4 @joshtriplett