Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add intra-doc links to size_of_* functions #110347

Merged
merged 1 commit into from
Apr 16, 2023
Merged

Add intra-doc links to size_of_* functions #110347

merged 1 commit into from
Apr 16, 2023

Conversation

est31
Copy link
Member

@est31 est31 commented Apr 15, 2023

Also some smaller doc improvements.

@rustbot
Copy link
Collaborator

rustbot commented Apr 15, 2023

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 15, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 15, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

jyn514
jyn514 reviewed Apr 15, 2023
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these look like good improvements 👍 I left a comment on the ones I wasn't sure about.

library/core/src/mem/mod.rs Show resolved Hide resolved
library/core/src/mem/mod.rs Outdated Show resolved Hide resolved
@est31
Copy link
Member Author

est31 commented Apr 15, 2023

r? @jyn514

@rustbot rustbot assigned jyn514 and unassigned cuviper Apr 15, 2023
@jyn514
Copy link
Member

jyn514 commented Apr 15, 2023

@bors r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented Apr 15, 2023

📌 Commit 504a47b has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2023
aliemjay added a commit to aliemjay/rust that referenced this pull request Apr 15, 2023
@aliemjay
Rollup merge of rust-lang#110347 - est31:size_of_links, r=jyn514
cccc358 
Add intra-doc links to size_of_* functions

Also some smaller doc improvements.
@aliemjay aliemjay mentioned this pull request Apr 15, 2023
Closed
aliemjay added a commit to aliemjay/rust that referenced this pull request Apr 15, 2023
@aliemjay
Rollup merge of rust-lang#110347 - est31:size_of_links, r=jyn514
1cd15de 
Add intra-doc links to size_of_* functions

Also some smaller doc improvements.
@aliemjay aliemjay mentioned this pull request Apr 15, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 15, 2023
@matthiaskrgr
Rollup merge of rust-lang#110347 - est31:size_of_links, r=jyn514
1b4d305 
Add intra-doc links to size_of_* functions

Also some smaller doc improvements.
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 15, 2023
Closed
@JohnTitor JohnTitor mentioned this pull request Apr 15, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 16, 2023
@bors
Auto merge of rust-lang#110375 - JohnTitor:rollup-ghvdaxm, r=JohnTitor
c6fb7b9 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#110033 (Add 1.69.0 release notes)
 - rust-lang#110272 (fix: skip implied bounds if unconstrained lifetime exists)
 - rust-lang#110307 (Allow everyone to set the beta-nominated label)
 - rust-lang#110347 (Add intra-doc links to size_of_* functions)
 - rust-lang#110350 (Add a UI test for rust-lang#79605)
 - rust-lang#110356 (Fix `x test rust-installer` when `cargo` is set to a relative path)
 - rust-lang#110364 (remove redundant clones)
 - rust-lang#110366 (fix some clippy::complexity)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1c228d1 into rust-lang:master Apr 16, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@jyn514 jyn514

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
5 participants
@est31 @rustbot @jyn514 @bors @cuviper