Enable DataflowConstProp by default #110691

cjgillot · 2023-04-22T15:13:35Z

cjgillot · 2023-04-22T15:13:55Z

bors · 2023-04-22T15:14:04Z

⌛ Trying commit bb0cf0a2f940a562fa8da2c973a91264f1bf543f with merge 2bc91dddae35541bc0e74326de3768d8aaf330ec...

bors · 2023-04-22T16:54:18Z

☀️ Try build successful - checks-actions
Build commit: 2bc91dddae35541bc0e74326de3768d8aaf330ec (2bc91dddae35541bc0e74326de3768d8aaf330ec)

bors · 2023-04-22T16:54:18Z

☀️ Try build successful - checks-actions
Build commit: 2bc91dddae35541bc0e74326de3768d8aaf330ec (2bc91dddae35541bc0e74326de3768d8aaf330ec)

rust-timer · 2023-04-22T18:10:29Z

Finished benchmarking commit (2bc91dddae35541bc0e74326de3768d8aaf330ec): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.2%, 2.7%]	30
Regressions ❌ (secondary)	2.4%	[0.3%, 20.1%]	24
Improvements ✅ (primary)	-1.0%	[-2.1%, -0.4%]	20
Improvements ✅ (secondary)	-0.8%	[-1.4%, -0.3%]	10
All ❌✅ (primary)	0.0%	[-2.1%, 2.7%]	50

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.6%	[2.8%, 5.0%]	3
Regressions ❌ (secondary)	32.7%	[2.4%, 59.4%]	4
Improvements ✅ (primary)	-3.0%	[-6.1%, -0.8%]	5
Improvements ✅ (secondary)	-2.0%	[-2.3%, -1.6%]	2
All ❌✅ (primary)	-0.5%	[-6.1%, 5.0%]	8

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.8%	[1.8%, 1.8%]	1
Regressions ❌ (secondary)	6.2%	[1.9%, 14.0%]	3
Improvements ✅ (primary)	-1.7%	[-2.2%, -1.1%]	8
Improvements ✅ (secondary)	-2.4%	[-2.9%, -1.9%]	2
All ❌✅ (primary)	-1.3%	[-2.2%, 1.8%]	9

cjgillot · 2023-04-22T20:55:22Z

@bors try @rust-timer queue

bors · 2023-04-22T20:55:32Z

⌛ Trying commit 2f20d3a183c5d8b54bcc204938a5038e8d3597db with merge 12a1c635a0fa4b645001089033dcbc1a27ed7f95...

cjgillot · 2023-04-22T21:01:09Z

@bors try @rust-timer queue

bors · 2023-04-22T21:01:19Z

⌛ Trying commit 78aa186e9bff3cef800578d0510eb7365d3c02cc with merge 955340be54e5827d89bc08f50df59cd3eae063c4...

bors · 2023-04-22T22:42:18Z

☀️ Try build successful - checks-actions
Build commit: 955340be54e5827d89bc08f50df59cd3eae063c4 (955340be54e5827d89bc08f50df59cd3eae063c4)

bors · 2023-04-22T22:42:18Z

☀️ Try build successful - checks-actions
Build commit: 955340be54e5827d89bc08f50df59cd3eae063c4 (955340be54e5827d89bc08f50df59cd3eae063c4)

rust-timer · 2023-04-23T00:49:51Z

Finished benchmarking commit (955340be54e5827d89bc08f50df59cd3eae063c4): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.4%	[0.2%, 10.4%]	40
Regressions ❌ (secondary)	56.3%	[0.2%, 590.0%]	21
Improvements ✅ (primary)	-1.0%	[-2.0%, -0.6%]	20
Improvements ✅ (secondary)	-0.7%	[-1.3%, -0.2%]	9
All ❌✅ (primary)	1.3%	[-2.0%, 10.4%]	60

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	36.2%	[1.8%, 201.1%]	15
Regressions ❌ (secondary)	3328.2%	[1.6%, 11904.9%]	7
Improvements ✅ (primary)	-3.1%	[-4.4%, -0.8%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	29.6%	[-4.4%, 201.1%]	18

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.0%	[1.2%, 7.8%]	13
Regressions ❌ (secondary)	52.3%	[1.9%, 418.5%]	17
Improvements ✅ (primary)	-1.4%	[-2.0%, -0.8%]	8
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.9%	[-2.0%, 7.8%]	21

bors · 2023-07-25T16:49:29Z

☔ The latest upstream changes (presumably #114011) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2023-09-12T11:21:25Z

☔ The latest upstream changes (presumably #115705) made this pull request unmergeable. Please resolve the merge conflicts.

rust-log-analyzer · 2023-12-09T13:53:37Z

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v4' (SHA:b4ffde65f46336ab88eb53be808477a3936bae11)
Download action repository 'actions/upload-artifact@v3' (SHA:a8a3f3ad30e3422c9c7b888a15615d19a852ae32)
Complete job name: PR - mingw-check-tidy
git config --global core.autocrlf false
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
GITHUB_ACTION=__run_7
GITHUB_ACTIONS=true
GITHUB_ACTION_REF=
GITHUB_ACTION_REPOSITORY=
GITHUB_ACTOR=cjgillot
GITHUB_API_URL=https://api.github.com
GITHUB_BASE_REF=master
GITHUB_ENV=/home/runner/work/_temp/_runner_file_commands/set_env_1ec519b5-1c19-4dec-81d2-a1bc1b17d0c9
GITHUB_EVENT_NAME=pull_request
---
GITHUB_SERVER_URL=https://github.com
GITHUB_SHA=eea7ab918b9b355fdfeea309d4e452dbca88dc58
GITHUB_STATE=/home/runner/work/_temp/_runner_file_commands/save_state_1ec519b5-1c19-4dec-81d2-a1bc1b17d0c9
GITHUB_STEP_SUMMARY=/home/runner/work/_temp/_runner_file_commands/step_summary_1ec519b5-1c19-4dec-81d2-a1bc1b17d0c9
GITHUB_TRIGGERING_ACTOR=cjgillot
GITHUB_WORKFLOW_REF=rust-lang/rust/.github/workflows/ci.yml@refs/pull/110691/merge
GITHUB_WORKFLOW_SHA=eea7ab918b9b355fdfeea309d4e452dbca88dc58
GITHUB_WORKSPACE=/home/runner/work/rust/rust
GOROOT_1_19_X64=/opt/hostedtoolcache/go/1.19.13/x64
---
Removing intermediate container 65ca1ec231b2
 ---> bf8884b76a2d
Step 6/10 : COPY host-x86_64/mingw-check/reuse-requirements.txt /tmp/
 ---> 8bd8f93d9825
Step 7/10 : RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-requirements.txt     && pip3 install virtualenv
Collecting binaryornot==0.4.4
  Downloading binaryornot-0.4.4-py2.py3-none-any.whl (9.0 kB)
Collecting boolean-py==4.0
  Downloading boolean.py-4.0-py3-none-any.whl (25 kB)
---
  Downloading virtualenv-20.25.0-py3-none-any.whl (3.8 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.8/3.8 MB 17.9 MB/s eta 0:00:00
Collecting filelock<4,>=3.12.2
  Downloading filelock-3.13.1-py3-none-any.whl (11 kB)
Collecting platformdirs<5,>=3.9.1
  Downloading platformdirs-4.1.0-py3-none-any.whl (17 kB)
Collecting distlib<1,>=0.3.7
  Downloading distlib-0.3.7-py2.py3-none-any.whl (468 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 468.9/468.9 KB 36.6 MB/s eta 0:00:00
Installing collected packages: distlib, platformdirs, filelock, virtualenv
Successfully installed distlib-0.3.7 filelock-3.13.1 platformdirs-4.1.0 virtualenv-20.25.0
Removing intermediate container 9cc2f9bbc5a8
 ---> c9fca327977d
Step 8/10 : COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
 ---> 53fd6caefa57
 ---> 53fd6caefa57
Step 9/10 : COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/
 ---> fb8d6d3f2593
Step 10/10 : ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test            --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
Removing intermediate container fdedb51252b2
 ---> 66fb2b1774a8
Successfully built 66fb2b1774a8
Successfully tagged rust-ci:latest
Successfully tagged rust-ci:latest
##[endgroup]
Built container sha256:66fb2b1774a8783d8d6dbca99428ed8c6bcafa71f939e87ad6f2b2e4623b4a24
Uploading finished image sha256:66fb2b1774a8783d8d6dbca99428ed8c6bcafa71f939e87ad6f2b2e4623b4a24 to https://ci-caches.rust-lang.org/docker/139141a603ff222e98d20ef66f0e4eaedfc4b373e41d302ecff577f90ee0c6cf0cab092d18a8f6a073c88b362b9a680d3b2b6e5c828faaf25d1b853eabb78b1a
IMAGE          CREATED                  CREATED BY                                      SIZE      COMMENT
66fb2b1774a8   Less than a second ago   /bin/sh -c #(nop)  ENV SCRIPT=TIDY_PRINT_DIF…   0B        
53fd6caefa57   2 seconds ago            /bin/sh -c #(nop) COPY file:078ea1d11e7b7cda…   367B      
c9fca327977d   3 seconds ago            |1 DEBIAN_FRONTEND=noninteractive /bin/sh -c…   23.9MB    
8bd8f93d9825   11 seconds ago           /bin/sh -c #(nop) COPY file:ac591dd6bc5afa66…   5.33kB    
bf8884b76a2d   12 seconds ago           |1 DEBIAN_FRONTEND=noninteractive /bin/sh -c…   23.1MB    
---
<missing>      8 days ago               /bin/sh -c #(nop)  LABEL org.opencontainers.…   0B        
<missing>      8 days ago               /bin/sh -c #(nop)  ARG LAUNCHPAD_BUILD_ARCH     0B        
<missing>      8 days ago               /bin/sh -c #(nop)  ARG RELEASE                  0B        

<botocore.awsrequest.AWSRequest object at 0x7f86a6ca40d0>
gzip: stdout: Broken pipe
xargs: docker: terminated by signal 13
https://ci-caches.rust-lang.org/docker/139141a603ff222e98d20ef66f0e4eaedfc4b373e41d302ecff577f90ee0c6cf0cab092d18a8f6a073c88b362b9a680d3b2b6e5c828faaf25d1b853eabb78b1a
sha256:66fb2b1774a8783d8d6dbca99428ed8c6bcafa71f939e87ad6f2b2e4623b4a24
---
DirectMap4k:      253888 kB
DirectMap2M:     7086080 kB
DirectMap1G:    11534336 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test            --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
    Finished dev [unoptimized] target(s) in 0.03s
##[endgroup]
downloading https://ci-artifacts.rust-lang.org/rustc-builds-alt/ce670339c3a12e264fcabec1a05e218ff180b439/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz
extracting /checkout/obj/build/cache/llvm-ce670339c3a12e264fcabec1a05e218ff180b439-true/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm
---
    Finished release [optimized] target(s) in 24.25s
##[endgroup]
fmt check
tidy check
tidy error: the following output file is not associated with any mir-opt test, you can remove it: /checkout/tests/mir-opt/const_prop/tuple.main.ConstProp.diff
tidy error: the following output file is not associated with any mir-opt test, you can remove it: /checkout/tests/mir-opt/const_prop/enum.multiple.ConstProp.diff
tidy error: the following output file is not associated with any mir-opt test, you can remove it: /checkout/tests/mir-opt/const_prop/enum.mutate_discriminant.ConstProp.diff
tidy error: the following output file is not associated with any mir-opt test, you can remove it: /checkout/tests/mir-opt/const_prop/enum.simple.ConstProp.diff
removing old virtual environment
removing old virtual environment
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10'
Requirement already satisfied: pip in ./build/venv/lib/python3.10/site-packages (23.3.1)
Collecting black==23.3.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 7))
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.7/1.7 MB 13.4 MB/s eta 0:00:00
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.7/1.7 MB 13.4 MB/s eta 0:00:00
Collecting click==8.1.3 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 34))
  Downloading click-8.1.3-py3-none-any.whl (96 kB)
Collecting importlib-metadata==6.7.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 38))
  Downloading importlib_metadata-6.7.0-py3-none-any.whl (22 kB)
  Downloading importlib_metadata-6.7.0-py3-none-any.whl (22 kB)
Collecting mypy-extensions==1.0.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 42))
  Downloading mypy_extensions-1.0.0-py3-none-any.whl (4.7 kB)
Collecting packaging==23.1 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 46))
  Downloading packaging-23.1-py3-none-any.whl (48 kB)
Collecting pathspec==0.11.1 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 50))
  Downloading pathspec-0.11.1-py3-none-any.whl (29 kB)
  Downloading pathspec-0.11.1-py3-none-any.whl (29 kB)
Collecting platformdirs==3.6.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 54))
  Downloading platformdirs-3.6.0-py3-none-any.whl (16 kB)
Collecting ruff==0.0.272 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 58))
  Downloading ruff-0.0.272-py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (5.9 MB)
Collecting tomli==2.0.1 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 77))
  Downloading tomli-2.0.1-py3-none-any.whl (12 kB)
Collecting typed-ast==1.5.4 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 81))
  Downloading typed_ast-1.5.4-cp310-cp310-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (877 kB)
  Downloading typed_ast-1.5.4-cp310-cp310-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (877 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 877.7/877.7 kB 2.6 MB/s eta 0:00:00
Collecting typing-extensions==4.6.3 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 107))
  Downloading typing_extensions-4.6.3-py3-none-any.whl (31 kB)
Collecting zipp==3.15.0 (from -r /checkout/src/tools/tidy/config/requirements.txt (line 114))
  Downloading zipp-3.15.0-py3-none-any.whl (6.8 kB)
Installing collected packages: zipp, typing-extensions, typed-ast, tomli, ruff, platformdirs, pathspec, packaging, mypy-extensions, click, importlib-metadata, black
Successfully installed black-23.3.0 click-8.1.3 importlib-metadata-6.7.0 mypy-extensions-1.0.0 packaging-23.1 pathspec-0.11.1 platformdirs-3.6.0 ruff-0.0.272 tomli-2.0.1 typed-ast-1.5.4 typing-extensions-4.6.3 zipp-3.15.0
some tidy checks failed
Build completed unsuccessfully in 0:01:01
  local time: Sat Dec  9 13:53:29 UTC 2023
  network time: Sat, 09 Dec 2023 13:53:29 GMT

bors · 2023-12-10T05:41:59Z

☔ The latest upstream changes (presumably #118550) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 22, 2023