-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shrink error variants for layout and fn_abi #111035
Conversation
@bors try @rust-timer queue |
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
The Miri subtree was changed cc @rust-lang/miri Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
⌛ Trying commit 543503b7e9c79b6257493df1e770c9b2540d261c with merge 3cfdb3077f24cce228038d08eb41a9af12b43ac8... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (3cfdb3077f24cce228038d08eb41a9af12b43ac8): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
@Nilstrieb are you still interested in landing this? perf results seem neutral but I'd be happy to review myself after a rebase if you're still interested 🙂 |
r? wesleywiser |
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #111807) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
b429485
to
e8d2b7a
Compare
☔ The latest upstream changes (presumably #113022) made this pull request unmergeable. Please resolve the merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me after rebase
`LayoutError` is 24 bytes, which is bigger than the `Ok` types, so let's shrink that.
The `FnAbi` is just a pointer, so the error type should not be bigger.
@bors r=wesleywiser rollup=maybe |
☀️ Test successful - checks-actions |
1 similar comment
☀️ Test successful - checks-actions |
Finished benchmarking commit (ba76096): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 661.654s -> 662.486s (0.13%) |
The errors are bigger than the result, so let's put them behind a reference. Since query results have to be
Copy
, we use a reference into the arena instead of aBox<T>
.