Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asm: loongarch64: Drop efiapi #111499

Merged
merged 1 commit into from
May 13, 2023
Merged

asm: loongarch64: Drop efiapi #111499

merged 1 commit into from
May 13, 2023

Conversation

heiher
Copy link
Contributor

@heiher heiher commented May 12, 2023

This PR aims to drop efiapi which is not a valid ABI on LoongArch.

Fixes: #111237 (comment)

@rustbot
Copy link
Collaborator

rustbot commented May 12, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 12, 2023
@heiher
Copy link
Contributor Author

heiher commented May 12, 2023

r? @Amanieu

@rustbot rustbot assigned Amanieu and unassigned cjgillot May 12, 2023
@Amanieu
Copy link
Member

Amanieu commented May 12, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 12, 2023

📌 Commit d58863f has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2023
@Dylan-DPC Dylan-DPC mentioned this pull request May 13, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 13, 2023
@bors
Auto merge of rust-lang#111526 - Dylan-DPC:rollup-h75agro, r=Dylan-DPC
69fef92 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#110454 (Require impl Trait in associated types to appear in method signatures)
 - rust-lang#111096 (Add support for `cfg(overflow_checks)`)
 - rust-lang#111451 (Note user-facing types of coercion failure)
 - rust-lang#111469 (Fix data race in llvm source code coverage)
 - rust-lang#111494 (Encode `VariantIdx` so we can decode ADT variants in the right order)
 - rust-lang#111499 (asm: loongarch64: Drop efiapi)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1533eaf into rust-lang:master May 13, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 13, 2023
@heiher heiher deleted the drop-efiapi branch May 13, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
5 participants
@heiher @rustbot @Amanieu @bors @cjgillot