-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Pin
memory layout
#111711
Document Pin
memory layout
#111711
Conversation
r? @thomcc (rustbot has picked a reviewer for you, use r? to override) |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Yeah, this is already documented effectively, and can't be changed compatibly. I'm going to use my judgement that this doesn't need discussion in a meeting. @bors r+ rollup |
☀️ Test successful - checks-actions |
Finished benchmarking commit (48ec50a): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 644.433s -> 643.76s (-0.10%) |
... Given this is a comment-only change, we might want to up the significance threshold for the cargo-0.60.0-opt-incr-patched benchmark. Though I don't know who to ping for that, and it might actually be a derived property rather than a set one if I read the docs correctly. |
The fact that
Pin
is#[repr(transparent)]
technically isn't documented anywhere currently. I don't see any reason whyPin
's layout would ever change, so this PR codifies it.@rustbot label +T-libs-api -T-libs +A-docs +A-layout +A-pin