Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep only the trait when emitting the error for MyTrait + 'a #111731

Merged
merged 2 commits into from
May 21, 2023

Conversation

mu001999
Copy link
Contributor

Fixes #111727

@rustbot
Copy link
Collaborator

rustbot commented May 18, 2023

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 18, 2023
@mu001999
Copy link
Contributor Author

r? @fee1-dead

@rustbot rustbot assigned fee1-dead and unassigned jackh726 May 18, 2023
@mu001999
Copy link
Contributor Author

r? @cjgillot

@rustbot rustbot assigned cjgillot and unassigned fee1-dead May 19, 2023
@mu001999 mu001999 requested a review from cjgillot May 19, 2023 02:16
@mu001999 mu001999 force-pushed the fix/issue-111727 branch from 1cde43a to f676181 Compare May 19, 2023 07:24
@mu001999 mu001999 requested a review from cjgillot May 19, 2023 07:25
@mu001999 mu001999 force-pushed the fix/issue-111727 branch from f676181 to cf39281 Compare May 19, 2023 13:27
@mu001999 mu001999 requested a review from cjgillot May 19, 2023 13:31
@mu001999 mu001999 force-pushed the fix/issue-111727 branch from cf39281 to a9528a2 Compare May 19, 2023 14:13
@cjgillot
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 19, 2023

📌 Commit d573838 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2023
@bors
Copy link
Contributor

bors commented May 21, 2023

⌛ Testing commit d573838 with merge 9d871b0...

@bors
Copy link
Contributor

bors commented May 21, 2023

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 9d871b0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 21, 2023
@bors bors merged commit 9d871b0 into rust-lang:master May 21, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 21, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9d871b0): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.4% [-0.4%, -0.4%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.5% [3.5%, 3.5%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.8% [-2.8%, -2.8%] 1
All ❌✅ (primary) 3.5% [3.5%, 3.5%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 644.454s -> 644.264s (-0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: Failed to remove the prefix dyn
7 participants