-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize next_chunk impls for Filter and FilterMap #111781
Conversation
the8472
commented
May 20, 2023
r? @thomcc (rustbot has picked a reviewer for you, use r? to override) |
Nice improvement. The code is pretty complex, but seems correct and the benchmarks definitely justify it. @bors r+ rollup=never |
☀️ Test successful - checks-actions |
Finished benchmarking commit (7ca94f2): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 644.637s -> 643.892s (-0.12%) |