Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render test messages from bootstrap #111826

Merged
merged 1 commit into from
May 22, 2023

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented May 21, 2023

Bootstrap was not rendering messages from the test harness when a test failed. This can include messages like "test did not panic as expected". This fixes it by making sure those messages are printed on failure.

Fixes #111825

@rustbot
Copy link
Collaborator

rustbot commented May 21, 2023

r? @clubby789

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 21, 2023
@clubby789
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 21, 2023

📌 Commit 59dff76 has been approved by clubby789

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request May 22, 2023
…iaskrgr

Rollup of 2 pull requests

Successful merges:

 - rust-lang#111810 (Don't use inner macro in `marker_impls`)
 - rust-lang#111826 (Render test messages from bootstrap)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e2362d7 into rust-lang:master May 22, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

./x.py test does not explain why a #[should_panic] test failed
4 participants