-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pass --lib
to x doc
#112211
pass --lib
to x doc
#112211
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ozkanonur (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix.
Can you update the following as well?
Line 1576 in 0939ec1
// src/bootstrap/bin/{rustc.rs,rustdoc.rs} |
@rustbot author |
0373f55
to
a07b250
Compare
I'm short on time for reviews, please don't assign me. |
Question: How can I build this page on my localhost? I want to view these crates doc on my branch. |
@eval-exec try |
927d5e6
to
57287ae
Compare
If things goes more complicated than we expected, we can implement the first solution which was |
This comment has been minimized.
This comment has been minimized.
It's probably because you didn't build --
Yes please. Updating the binary name requires updating so many different spots in bootstrapping, which will fail the CI until we replace all of them correctly. So it's better to simply implement the first idea. |
57287ae
to
8657a64
Compare
|
bootstrap/bin/rustdoc.rs
to bootstrap/bin/rustdoc-shim.rs
--lib
to x doc
No worries, I tested it and it works well :) @bors r+ rollup |
…mpiler-errors Rollup of 6 pull requests Successful merges: - rust-lang#109609 (Separate AnonConst from ConstBlock in HIR.) - rust-lang#112166 (bootstrap: Rename profile = user to profile = dist) - rust-lang#112168 (Lower `unchecked_div`/`_rem` to MIR's `BinOp::Div`/`Rem`) - rust-lang#112183 (Normalize anon consts in new solver) - rust-lang#112211 (pass `--lib` to `x doc`) - rust-lang#112223 (Don't ICE in new solver when auto traits have associated types) r? `@ghost` `@rustbot` modify labels: rollup
@@ -834,6 +834,7 @@ macro_rules! tool_doc { | |||
cargo.arg("-Zskip-rustdoc-fingerprint"); | |||
// Only include compiler crates, no dependencies of those, such as `libc`. | |||
cargo.arg("--no-deps"); | |||
cargo.arg("--lib"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is passed for all tools, not just bootstrap. was that intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, missed it. Thanks for catching, will fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, I made a mistake. Thank you for your correction.
extend `tool_doc!` with `only_libs` arg resolves rust-lang#112211 (comment)
refactor `tool_doc!` resolves rust-lang#112211 (comment)
refactor `tool_doc!` resolves rust-lang#112211 (comment)
This PR want to close #112082