Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't double-print status messages in GHA #112299

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jun 5, 2023

Before:

Building stage0 tool jsondocck (x86_64-unknown-linux-gnu)
  Building stage0 tool jsondocck (x86_64-unknown-linux-gnu)
   Downloading crates ...

After:

Building stage0 tool jsondocck (x86_64-unknown-linux-gnu)
   Downloading crates ...

r? @oli-obk

Before:

```
Building stage0 tool jsondocck (x86_64-unknown-linux-gnu)
  Building stage0 tool jsondocck (x86_64-unknown-linux-gnu)
   Downloading crates ...
```

After:

```
Building stage0 tool jsondocck (x86_64-unknown-linux-gnu)
   Downloading crates ...
```
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 5, 2023
@jyn514 jyn514 marked this pull request as ready for review June 5, 2023 03:16
@oli-obk
Copy link
Contributor

oli-obk commented Jun 5, 2023

@bors r+ rollup

Ah yes, they don't get silently eaten, but actually show up in logs

@bors
Copy link
Contributor

bors commented Jun 5, 2023

📌 Commit af4e6c1 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 5, 2023
…llaumeGomez

Rollup of 6 pull requests

Successful merges:

 - rust-lang#112243 (Remove unneeded `Buffer` allocations when `&mut fmt::Write` can be used directly)
 - rust-lang#112263 (Remove ExtendElement, ExtendWith, extend_with)
 - rust-lang#112291 (Disable RustAnalyzer check by default, run Rustfmt check before)
 - rust-lang#112299 (Don't double-print status messages in GHA)
 - rust-lang#112311 (Ignore fluent message reordering in `git blame`)
 - rust-lang#112315 (fix spelling error)

Failed merges:

 - rust-lang#112251 (rustdoc: convert `if let Some()` that always matches to variable)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 154949d into rust-lang:master Jun 5, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants