Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "consider importing" consistent for macros #112452

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Make "consider importing" consistent for macros #112452

merged 1 commit into from
Jun 10, 2023

Conversation

mu001999
Copy link
Contributor

@mu001999 mu001999 commented Jun 9, 2023

Fixes #112439

@rustbot
Copy link
Collaborator

rustbot commented Jun 9, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 9, 2023
@petrochenkov
Copy link
Contributor

r=me with the nit addressed.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2023
@mu001999 mu001999 force-pushed the fix/issue-112439 branch from ffca979 to 5bd8ba8 Compare June 9, 2023 16:08
@petrochenkov
Copy link
Contributor

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Jun 9, 2023

📌 Commit 5bd8ba8 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 9, 2023
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 9, 2023
@GuillaumeGomez
Rollup merge of rust-lang#112452 - MU001999:fix/issue-112439, r=petro…
b6ca37c 
…chenkov

Make "consider importing" consistent for macros

Fixes rust-lang#112439
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 9, 2023
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 9, 2023
@GuillaumeGomez
Rollup merge of rust-lang#112452 - MU001999:fix/issue-112439, r=petro…
a031062 
…chenkov

Make "consider importing" consistent for macros

Fixes rust-lang#112439
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 9, 2023
Closed
@bors
Copy link
Contributor

bors commented Jun 10, 2023

⌛ Testing commit 5bd8ba8 with merge d0ee190...

@bors
Copy link
Contributor

bors commented Jun 10, 2023

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing d0ee190 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 10, 2023
@bors bors merged commit d0ee190 into rust-lang:master Jun 10, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 10, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d0ee190): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.6% [3.6%, 3.6%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.6% [3.6%, 3.6%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 648.751s -> 650.258s (0.23%)

@mu001999 mu001999 deleted the fix/issue-112439 branch June 11, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.

"Did you mean" for attributes should be the same style as functions
5 participants
@mu001999 @rustbot @petrochenkov @bors @rust-timer