Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add esp-idf missing targets #112559

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Add esp-idf missing targets #112559

merged 1 commit into from
Jun 26, 2023

Conversation

SergioGasquez
Copy link
Contributor

@SergioGasquez SergioGasquez commented Jun 12, 2023

Adds some esp-idf missing targets to the table

@rustbot
Copy link
Collaborator

rustbot commented Jun 12, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 12, 2023
@JohnTitor
Copy link
Member

Sorry for the delay! @bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 26, 2023

📌 Commit c0aed70 has been approved by JohnTitor

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 26, 2023
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#111326 (Add support for NetBSD/aarch64-be (big-endian arm64).)
 - rust-lang#112559 (Add esp-idf missing targets)
 - rust-lang#112840 (doc: loongarch: Update maintainers)
 - rust-lang#112955 (CI: cancel in-progress workflow runs after a push)
 - rust-lang#112979 (Rewrite most diagnostics as translatable within resolve/imports)
 - rust-lang#113034 (Switch some more Steps to `builder.msg`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ac84b66 into rust-lang:master Jun 26, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 26, 2023
@riking
Copy link

riking commented Jun 29, 2023

We don't add a line for every possible CPU, but instead one or maybe two example CPUs for the target string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants