-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: render generic params & where-clauses of cross-crate assoc tys in impls #112920
Conversation
r? @jsha (rustbot has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #112974) made this pull request unmergeable. Please resolve the merge conflicts. |
b3053b7
to
c643bed
Compare
Note to reviewers: The diff looks unnecessarily complex (split diff is slightly better). Basically I just moved the code responsible for obtaining the Apart from that, I've added an extra (I've also changed the indentation of the if/let-chains found in the code block I've moved since it didn't align with the style guide ( |
Thanks! @bors r+ rollup |
Rollup of 2 pull requests Successful merges: - rust-lang#112677 (remove unused field) - rust-lang#112920 (rustdoc: render generic params & where-clauses of cross-crate assoc tys in impls) r? `@ghost` `@rustbot` modify labels: rollup
☔ The latest upstream changes (presumably #113057) made this pull request unmergeable. Please resolve the merge conflicts. |
We used to only ever render generic parameters & where-clauses of cross-crate associated types when the item was located inside of a trait and we used to just drop them when it was inside of an impl block (trait or inherent).
Fixes #112904.
@rustbot label A-cross-crate-reexports