Rollup of 4 pull requests #112964
Closed
Rollup of 4 pull requests #112964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fd3d2d4. This has the side effect, that when Clippy should ICE (during an EarlyPass?) it will fill up the RAM with 2 GB/s and then freezes the PC. I don't know the correct solution, but this is blocking the Clippy sync and might give some people really bad experiences, so this should be reverted ASAP.
…ce, r=cjgillot Revert "Don't hold the active queries lock while calling `make_query`" This reverts commit fd3d2d4. This has the side effect, that when Clippy should ICE (during an EarlyPass?) it will fill up the RAM with 2 GB/s and then freezes the PC. I don't know the correct solution, but this is blocking the Clippy sync and might give some people really bad experiences, so this should be reverted ASAP. Reverts rust-lang#112333 r? `@cjgillot` cc `@Zoxc` I only commented this on [Zulip](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/.60try_print_query_stack.60.20has.20.60ImplicitCtx.60.20during.20.60EarlyPass.60/near/363926180). I should've left a comment on the PR as well. My bad.
…ter, r=notriddle Add link to rustdoc book search chapter in help popover One thing that was missing in the rustdoc output and its help popover was a link back to the search feature chapter in the rustdoc book. It looks like this:  r? `@notriddle`
Stop hiding const eval limit in external macros fixes rust-lang#112748 We don't emit a hard error if there was a previous deny lint triggering with the same message. If that lint ends up not being emitted, we ICE and don't emit an error either.
…, r=notriddle [tests/rustdoc] Add @files command The ``@!has`` checks is very problematic as it wouldn't catch if the file scheme is updated and the file is generated again. ``@files`` allows to ensure that the given folder contains exactly the provided entries (files and folders). I'm wondering if we should forbid the ``@!has`` for files. To be discussed after this PR I suppose. r? `@notriddle`
rustbot
added
A-query-system
|
@bors r+ p=4 rollup=never |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 1ab9dd1 with merge 6873b1ff3b21425e3f0b4f13a064e26f8fbcf996... |
|
@GuillaumeGomez #112708 breaks those rollups, see #112708 (comment) You might want to cancel this rollup and start one without the PR. Sorry for not taking it out of the queue earlier. |
bors
added
S-waiting-on-author
|
Thanks for letting me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
make_query")r? @ghost
@rustbot modify labels: rollup
Create a similar rollup