-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust-installer & rls: remove exclusion from rustfmt & tidy #113010
Conversation
r? @ozkanonur (rustbot has picked a reviewer for you, use r? to override) |
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
Note for self: add #112884 (comment) back |
Is rls still maintained? |
I see it here https://rust-lang.github.io/rustup-components-history/ so yes, until removed? Currently rls is just stab to warn about deprecation. |
src/tools/tidy/src/bins.rs
Outdated
@@ -95,6 +95,15 @@ mod os_impl { | |||
return true; | |||
} | |||
|
|||
// FIXME: remove this when rust-installer test sh files changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some extra details would be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reworded in RI_EXCLUSION_LIST
.
This comment has been minimized.
This comment has been minimized.
@rustbot label -S-blocked |
@bors r+ rollup |
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#113010 (rust-installer & rls: remove exclusion from rustfmt & tidy ) - rust-lang#113317 ( -Ztrait-solver=next: stop depending on old solver) - rust-lang#113319 (`TypeParameterDefinition` always require a `DefId`) - rust-lang#113320 (Add some extra information to opaque type cycle errors) - rust-lang#113321 (Move `ty::ConstKind` to `rustc_type_ir`) - rust-lang#113337 (Winnow specialized impls during selection in new solver) - rust-lang#113355 (Move most coverage code out of `rustc_codegen_ssa`) - rust-lang#113356 (Add support for NetBSD/riscv64 aka. riscv64gc-unknown-netbsd.) r? `@ghost` `@rustbot` modify labels: rollup
based on #112884rust-installer
andrls
no longer submodules, but not removed from exclude list for rustfmt and tidy, preventing running fmt and lints on them.