rustdoc: get rid of extra line when line-wrapping fn decls with empty arg list #113013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jsha (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
fmease
commented
Jun 24, 2023
| pub struct Padding00000000000000000000000000000000000000000000000000000000000000000000000000000000; | ||
|
|
||
| // @has 'decl_line_wrapping_empty_arg_list/fn.create.html' | ||
| // @snapshot decl - '//pre[@class="rust item-decl"]' |
There was a problem hiding this comment.
Using @snapshot instead of @has since I couldn't figure out if it was possible to test for the presence of line breaks with it (I love the Htmldocck DSL ^^).
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 25, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#112976 (Add test for futures with HRTB) - rust-lang#113013 (rustdoc: get rid of extra line when line-wrapping fn decls with empty arg list) - rust-lang#113030 (Add a regression test for rust-lang#109071) - rust-lang#113031 (Add a regression test for rust-lang#110933) - rust-lang#113036 (Accept `ReStatic` for RPITIT) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bevyengine/bevy#8898 (comment):
It now prints as shown below (which conforms to the style guide):
The bug was introduced in #109011.