Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test for #96258 #113018

Merged
merged 1 commit into from
Jun 25, 2023
Merged

Fix test for #96258 #113018

merged 1 commit into from
Jun 25, 2023

Conversation

asquared31415
Copy link
Contributor

@asquared31415 asquared31415 commented Jun 25, 2023 •
edited
Loading

#98644 did not properly test enabling the problematic lint as a warning due to improper use of compile-flags: (missing :). This makes it use #![warn] instead, like in the reproducer.

cc #96258

@rustbot
Copy link
Collaborator

rustbot commented Jun 25, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 25, 2023
@TaKO8Ki
Copy link
Member

TaKO8Ki commented Jun 25, 2023

Thanks! @bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 25, 2023

📌 Commit 9dd655f has been approved by TaKO8Ki

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 25, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 25, 2023
@bors
Auto merge of rust-lang#113022 - GuillaumeGomez:rollup-vkpzsuw, r=Gui…
0d03812 
…llaumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#112918 (display PID of process holding lock)
 - rust-lang#112990 (Add a regression test for rust-lang#96699)
 - rust-lang#113011 (Add enum for `can_access_statics` boolean)
 - rust-lang#113018 (Fix test for rust-lang#96258)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a3c147b into rust-lang:master Jun 25, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 25, 2023
@asquared31415 asquared31415 deleted the test_fix branch July 26, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
5 participants
@asquared31415 @rustbot @TaKO8Ki @bors @cjgillot