Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document tracking issue for rustdoc show-type-layout #113249

Merged
merged 1 commit into from
Jul 2, 2023

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Jul 1, 2023

Tracking issue: #113248

@rustbot label +T-rustdoc +A-docs

@rustbot
Copy link
Collaborator

rustbot commented Jul 1, 2023

r? @jsha

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 1, 2023
@tgross35
Copy link
Contributor Author

tgross35 commented Jul 1, 2023

Just since you're currently active on zulip

r? @GuillaumeGomez

@rustbot rustbot assigned GuillaumeGomez and unassigned jsha Jul 1, 2023
@@ -310,6 +310,8 @@ the source.

### `--show-type-layout`: add a section to each type's docs describing its memory layout

* Trackin issue: [#113248](https://github.com/rust-lang/rust/issues/113248)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Trackin issue: [#113248](https://github.com/rust-lang/rust/issues/113248)
* Tracking issue: [#113248](https://github.com/rust-lang/rust/issues/113248)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected to say Trackin' issue instead of Trackin issue

(just kidding, should be resolved)

@jyn514
Copy link
Member

jyn514 commented Jul 1, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 1, 2023

📌 Commit 4fae271 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2023
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jul 2, 2023
Document tracking issue for rustdoc `show-type-layout`

Tracking issue: rust-lang#113248

`@rustbot` label +T-rustdoc +A-docs
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 2, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#113147 (Fix document examples of Vec::from_raw_parts and Vec::from_raw_parts_in)
 - rust-lang#113202 (std docs: factorize literal in Barrier example)
 - rust-lang#113228 (Migrate GUI colors test to original CSS color format)
 - rust-lang#113231 (Fix `dropping_copy_types` lint from linting in match-arm with side-effects)
 - rust-lang#113233 (Update chalk)
 - rust-lang#113234 (Don't pass --test-args to `python -m unitest`)
 - rust-lang#113244 (Make Rust Analyzer tests faster by compiling less code)
 - rust-lang#113249 (Document tracking issue for rustdoc `show-type-layout`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fde4102 into rust-lang:master Jul 2, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jul 2, 2023
@tgross35 tgross35 deleted the patch-2 branch July 2, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants