-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable test_join test in Miri #113287
enable test_join test in Miri #113287
Conversation
r? @m-ou-se (rustbot has picked a reviewer for you, use r? to override) |
Neat! @bors r+ r? @JohnTitor |
☀️ Test successful - checks-actions |
1 similar comment
☀️ Test successful - checks-actions |
Finished benchmarking commit (d9c13cd): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 658.838s -> 658.504s (-0.05%) |
Miri for quite a while now has a hack to support self-referential generators: non-
Unique
mutable references are exempt from aliasing conditions. So we can run this test now. (It passes.)Also extend a comment in a Vec test, while I am at it.