-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable some coverage tests on Linux #113389
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
@rustbot label +A-code-coverage |
From what I can tell, #110393 (comment) is referring to disabling these tests temporarily, in the hopes that future |
(I'm using #112514 to verify that these tests will indeed work on Linux, since the → success https://github.com/rust-lang/rust/actions/runs/5470324669/jobs/9960279192 |
@bors r+ rollup=iffy |
☀️ Test successful - checks-actions |
Finished benchmarking commit (70d7283): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 659.399s -> 658.067s (-0.20%) |
These tests were originally disabled (on all platforms) in #110393, because those changes had made them start failing on Linux for unclear reasons.
I tried to re-enable them unconditionally in #111179, since they worked locally on my Mac, but I found that they were still failing on Linux, so I gave up at that time.
Later while working on #112300 I was able to re-enable them on Windows and Mac, since those changes made it possible to add specific
ignore-
directives to individual tests. I noticed at the time that the tests actually seemed to be working again on Linux, but by that point I didn't want to risk more CI failures, so I left them disabled on Linux with an intention to re-enable them later.Now I'm going back to re-enable them on Linux too, since they seem to work fine.
Because
run-coverage
tests are sensitive to line numbers, andx test tidy
doesn't like leading blank lines, I've replaced the old comment/ignore with an informative comment that occupies the same number of lines.