Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Clippy beta backport #113417

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented Jul 6, 2023

Backported PRs:

Those address bugs, that were either introduced with 1.71 and that we would like to address before they get into stable or bugs that were introduced in 1.70 and that we would like to be fixed in 1.71 already.

Detailed arguments for the backports of those PRs are in the PRs (mostly).

r? @Mark-Simulacrum

y21 and others added 4 commits July 6, 2023 19:37
…ing, r=Jarcho

[`let_with_type_underscore`]: Don't emit on locals from procedural macros

closes rust-lang#10498

changelog: [`let_with_type_underscore`]: Don't emit on locals from procedural macros
@rustbot
Copy link
Collaborator

rustbot commented Jul 6, 2023

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 6, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jul 6, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@Manishearth
Copy link
Member

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jul 6, 2023

📌 Commit 8cde275 has been approved by Manishearth

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2023
@Manishearth
Copy link
Member

@bors r-

wait no, release team should approve, sorry

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 6, 2023
@Mark-Simulacrum
Copy link
Member

@bors r=Manishearth

Feel free to land commits on beta without asking release/me -- though a ping on Zulip or here is appreciated so we know that we need to land commits prior to branching.

@bors
Copy link
Contributor

bors commented Jul 6, 2023

📌 Commit 8cde275 has been approved by Manishearth

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 6, 2023
@bors
Copy link
Contributor

bors commented Jul 6, 2023

⌛ Testing commit 8cde275 with merge f06c1b8...

@bors
Copy link
Contributor

bors commented Jul 7, 2023

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing f06c1b8 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 7, 2023
@bors bors merged commit f06c1b8 into rust-lang:beta Jul 7, 2023
@rustbot rustbot added this to the 1.71.0 milestone Jul 7, 2023
@flip1995 flip1995 deleted the clippy_beta_backport branch July 7, 2023 10:00
@flip1995
Copy link
Member Author

flip1995 commented Jul 7, 2023

though a ping on Zulip or here is appreciated so we know that we need to land commits prior to branching.

If that works for you @Mark-Simulacrum, I'll just continue to r? @Mark-Simulacrum on those PRs.

@Mark-Simulacrum
Copy link
Member

That's fine too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants