Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap: Clean up try_run #113643

Merged
merged 3 commits into from
Jul 16, 2023
Merged

bootstrap: Clean up try_run #113643

merged 3 commits into from
Jul 16, 2023

Commits on Jul 15, 2023

  1. Deduplicate Builder::try_run and mark Config::try_run as deprecated 

    This does three things:
1. Remove `forward!(Build, fn try_run())`. Having `try_run` behave differently as a free function than an associated function is confusing, and `Builder::try_run` is a very desirable name.
2. Move `test::try_run` and `run::try_run` to `Builder::try_run`. These functions are different than `Config::try_run` - they delay the failure and print it out at the end of the build.
3. Mark `Config::try_run` as deprecated to encourage people to use `Builder::try_run` instead.
    @jyn514
    jyn514 committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    63d7992 View commit details
    Browse the repository at this point in the history

  2. Rename Builder::try_run to run_delaying_failure

    @jyn514
    jyn514 committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    78f51a4 View commit details
    Browse the repository at this point in the history

  3. Replace builder::try_run_quiet with run_quiet_delaying_failure 

    It was only used when a `builder` is available, and I want to encourage using the version that supports `--no-fail-fast`.
    @jyn514
    jyn514 committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    c0c6a24 View commit details
    Browse the repository at this point in the history