-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CFI: Fix ICE: encode_const: unexpected type [usize #113708
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs rebase
1ab7a67
to
dee5914
Compare
This comment has been minimized.
This comment has been minimized.
Fixes rust-lang#100778 and rust-lang#113366, and complements rust-lang#106547 by adding support for encoding const parameters.
dee5914
to
55dea62
Compare
Done. Thank you for your time, @compiler-errors! Much appreciated. |
@bors r+ |
⌛ Testing commit 55dea62 with merge a59ae33b2f7561faf938eb1c83037ee5a4fbaa8c... |
☀️ Test successful - checks-actions |
👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward |
:( bors @bors retry |
Finished benchmarking commit (a59ae33b2f7561faf938eb1c83037ee5a4fbaa8c): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 649.74s -> 650.357s (0.09%) |
☀️ Test successful - checks-actions |
Finished benchmarking commit (d150dbb): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 656.285s -> 653.837s (-0.37%) |
Fixes #100778 and #113366, and complements #106547 by adding support for encoding const parameters.