Convert builtin "global" late lints to run per module

[cjgillot]

The compiler currently has 4 non-incremental lints:

1. clashing_extern_declarations;
2. missing_debug_implementations;
3. unnameable_test_items; changed by Make test harness lint about unnnameable tests. #114414
4. missing_docs.

Non-incremental lints get reexecuted for each compilation, which is slow. Moreover, those lints are allow-by-default, so run for nothing most of the time. This PR attempts to make them more incremental-friendly.

clashing_extern_declarations is moved to a standalone query.

missing_debug_implementation can use non_blanket_impls_for_ty instead of recomputing it.

missing_docs is harder as it needs to track if there is a doc(hidden) module surrounding. I hack around this using the lint level engine. That's easy to implement and allows to re-enable the lint for a re-exported module, while a more proper solution would reuse the same device as unnameable_test_items.

[rustbot]

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

[cjgillot]

@bors try @rust-timer queue

[bors]

⌛ Trying commit f79296b3077e49380fb3b70761fab33d65e413a0 with merge 48a02fa0c7ccb590217148ef329202c4883e7230...

[bors]

☀️ Try build successful - checks-actions
Build commit: 48a02fa0c7ccb590217148ef329202c4883e7230 (48a02fa0c7ccb590217148ef329202c4883e7230)

[rust-timer]

Finished benchmarking commit (48a02fa0c7ccb590217148ef329202c4883e7230): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.9%	[0.7%, 1.0%]	4
Improvements ✅ (primary)	-2.2%	[-4.2%, -0.6%]	108
Improvements ✅ (secondary)	-5.2%	[-26.7%, -0.2%]	72
All ❌✅ (primary)	-2.2%	[-4.2%, -0.6%]	108

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[2.5%, 2.5%]	1
Improvements ✅ (primary)	-2.5%	[-6.5%, -0.6%]	95
Improvements ✅ (secondary)	-6.0%	[-13.3%, -0.7%]	62
All ❌✅ (primary)	-2.5%	[-6.5%, -0.6%]	95

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.6%	[-7.1%, -1.5%]	86
Improvements ✅ (secondary)	-7.9%	[-28.2%, -2.1%]	52
All ❌✅ (primary)	-3.6%	[-7.1%, -1.5%]	86

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.2%]	4
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	2
All ❌✅ (primary)	0.1%	[0.1%, 0.2%]	4

Bootstrap: 657.257s -> 656.692s (-0.09%)

[cjgillot]

cc @rust-lang/rustdoc for the change to missing docs lint.

[cjgillot]

r? compiler

[petrochenkov]

@bors r+

[bors]

📌 Commit 905b63d has been approved by petrochenkov

It is now in the queue for this repository.

[bors]

⌛ Testing commit 905b63d with merge 67626b8...

[bors]

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 67626b8 to master...

[rust-timer]

Finished benchmarking commit (67626b8): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.4%, 0.8%]	3
Improvements ✅ (primary)	-1.7%	[-3.4%, -0.2%]	88
Improvements ✅ (secondary)	-4.2%	[-26.5%, -0.2%]	85
All ❌✅ (primary)	-1.7%	[-3.4%, -0.2%]	88

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-3.0%	[-8.8%, -0.5%]	105
Improvements ✅ (secondary)	-6.1%	[-12.2%, -0.6%]	66
All ❌✅ (primary)	-3.0%	[-8.8%, -0.5%]	105

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.9%	[-5.3%, -1.7%]	54
Improvements ✅ (secondary)	-8.4%	[-28.8%, -1.1%]	56
All ❌✅ (primary)	-2.9%	[-5.3%, -1.7%]	54

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.1%]	4
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.1%]	4

Bootstrap: 650.338s -> 649.856s (-0.07%)

[Kobzol]

Awesome results!