-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename arg_iter
to iter_instantiated
#113801
Conversation
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
@bors r+ |
📌 Commit 781b1042456e958a3676da69e3bdd36887ffd785 has been approved by It is now in the queue for this repository. |
☔ The latest upstream changes (presumably #113686) made this pull request unmergeable. Please resolve the merge conflicts. |
781b104
to
05f6890
Compare
@bors r=oli-obk |
☀️ Test successful - checks-actions |
Finished benchmarking commit (6b9236e): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 657.921s -> 658.29s (0.06%) |
arg_iter
doesn't make sense, and doesn't really indicate what it's doing (returning an iterator thatsubstitutesinstantiates its elements).iter_instantiated_copied
is kinda awkward but i don't really wanna bikeshed it.r? @oli-obk