-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make {Rc,Arc}::allocator associated functions #113810
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Context: #89132 (comment), that PR just landed a few hours ago.
I'm marking this prioritize since it fixes a (just recently introduced) namespace regression on types like Rc<Vec<T>>
- but chance of that conflict is pretty small, so feel free to adjust if this isn't suitable.
@rustbot label +I-prioritize -T-libs +T-libs-api +A-allocators
r? libs-api |
Pretty easy to id but here's a repro #![feature(allocator_api)]
use std::rc::Rc;
struct Foo;
impl Foo {
fn allocator(&self) -> u32 { 100 }
}
fn main() {
let rc = Rc::new(Foo);
dbg!(rc.allocator());
} Output on latest nightly:
Output on older nightly:
|
@tgross35 we use the @rustbot label -I-prioritize |
Whoops, "Indicates that prioritization has been requested for this issue" I can see why that can be read two different ways. In that case, @Amanieu reviewed the other PR so may want to do this one. r? amanieu |
@bors r+ |
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#113380 (style-guide: clean up "must"/"should"/"may") - rust-lang#113723 (Resurrect: rustc_llvm: Add a -Z `print-codegen-stats` option to expose LLVM statistics.) - rust-lang#113780 (Support `--print KIND=PATH` command line syntax) - rust-lang#113810 (Make {Rc,Arc}::allocator associated functions) - rust-lang#113907 (Minor improvements to Windows TLS dtors) Failed merges: - rust-lang#113392 (style-guide: Some cleanups from the fmt-rfcs repo history) r? `@ghost` `@rustbot` modify labels: rollup
No description provided.