Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #113890

Merged
merged 28 commits into from
Jul 20, 2023
Merged

Rollup of 7 pull requests #113890

merged 28 commits into from
Jul 20, 2023

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

wackbyte and others added 28 commits June 23, 2023 18:39
…tor appearance (padding)

to look identical on Firefox. New versions of Firefox appear to have changed behavior to agree with Chrome.
… r=fmease,GuillaumeGomez

rustdoc: fix position of `default` in method rendering

With the following code:
```rs
#![feature(specialization)]

pub trait A {
    unsafe fn a();
}

impl A for () {
    default unsafe fn a() {}
}
```
rustdoc would render the `impl` of `a` as
```rs
unsafe default fn a()
```
which is inconsistent with the actual position of `default`.
This PR fixes this issue.
…wesleywiser

Permit pre-evaluated constants in simd_shuffle

fixes rust-lang#113500
Avoid another gha group nesting

fixes rust-lang#113798 (`x test error_index_generator` did not work locally anymore)

r? ``@jyn514``
Add Foreign, Never, FnDef, Closure and Generator tys to SMIR

r? ``@oli-obk``
…ng-self-ty, r=compiler-errors

new solver: don't consider blanket impls multiple times

only consider candidates which rely on the self type in `assemble_candidates_after_normalizing_self_ty`.

r? ``@compiler-errors``
…ctor-padding, r=GuillaumeGomez

Remove outdated Firefox-specific CSS for search's crate selector appearance

Remove adjustments that used to be necessary for search's crate selector appearance (padding) to look identical on Firefox. New versions of Firefox appear to have changed behavior to agree with Chrome.

As briefly discussed in rust-lang#98855 (comment)

r? ``@GuillaumeGomez``
…e, r=davidtwco

Don't translate compiler-internal bug messages

These are not very useful to be translated, as

* translators would get really weird and bad english versions to start out from,
* compiler devs have to do some work for what is supposed to be dead code and just a sanity check,
* the target audience is other compiler devs.

r? `@davidtwco`
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 20, 2023
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative rollup A PR which is a rollup labels Jul 20, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=7

@bors
Copy link
Contributor

bors commented Jul 20, 2023

📌 Commit 464e02a has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2023
@bors
Copy link
Contributor

bors commented Jul 20, 2023

⌛ Testing commit 464e02a with merge 092e4f4...

@bors
Copy link
Contributor

bors commented Jul 20, 2023

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 092e4f4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 20, 2023
@bors bors merged commit 092e4f4 into rust-lang:master Jul 20, 2023
11 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Jul 20, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#110765 rustdoc: fix position of default in method rendering 5449a5c31f404d01f824b04cf0ee1953a1243460 (link)
#113529 Permit pre-evaluated constants in simd_shuffle bc94babaae49af8ed0b98b77da432a3edc66523a (link)
#113800 Avoid another gha group nesting 8fa743b528e7df5146f4d6dc2bd4d0320a4e6c3f (link)
#113827 Add Foreign, Never, FnDef, Closure and Generator tys to SMIR 2777fcd3e153ff95f38f7558a88906f52cfc7e57 (link)
#113835 new solver: don't consider blanket impls multiple times 7d9a2cbead83ddad18df37f1e556c9bc9aa936dd (link)
#113883 Remove outdated Firefox-specific CSS for search's crate sel… 63c1d3dbf76fe70cd7545d037aad19c205ebb4a2 (link)
#113884 Don't translate compiler-internal bug messages 0142688bbd34c1d1dca0dfcbcf5c8e5076a505e3 (link)

previous master: 06a53ddc0b

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (092e4f4): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.2% [0.2%, 0.2%] 1
Improvements ✅
(primary)
-0.3% [-0.3%, -0.2%] 4
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.3% [-0.3%, -0.2%] 4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.3% [2.3%, 2.3%] 1
Regressions ❌
(secondary)
1.8% [1.2%, 2.5%] 2
Improvements ✅
(primary)
-2.1% [-2.4%, -1.7%] 6
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.4% [-2.4%, 2.3%] 7

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.2% [-1.2%, -1.2%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.2% [-1.2%, -1.2%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 649.387s -> 650.008s (0.10%)

@rustbot rustbot added the perf-regression Performance regression. label Jul 20, 2023
@pnkfelix
Copy link
Member

@rustbot label: +perf-regression-triaged

(a sole 0.2% regression to a secondary benchmark is not worth taking time to dissect IMO.)

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Jul 26, 2023
@matthiaskrgr matthiaskrgr deleted the rollup-k1w2vii branch March 16, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants