Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment stuff in the new solver #113987

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Comment stuff in the new solver #113987

merged 2 commits into from
Jul 24, 2023

Conversation

compiler-errors
Copy link
Member

r? @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative labels Jul 23, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jul 23, 2023

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

lcnr
lcnr reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after nits

compiler/rustc_trait_selection/src/solve/alias_relate.rs Outdated Show resolved Hide resolved
compiler/rustc_trait_selection/src/solve/mod.rs Outdated Show resolved Hide resolved
compiler/rustc_trait_selection/src/solve/weak_types.rs Outdated Show resolved Hide resolved
@compiler-errors @lcnr
lcnr's suggestions
3ad3bb6 
Co-authored-by: lcnr <rust@lcnr.de>
@compiler-errors
Copy link
Member Author

@bors r=lcnr rollup (just comments)

@bors
Copy link
Contributor

bors commented Jul 24, 2023

📌 Commit 3ad3bb6 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 24, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 24, 2023
@bors
Auto merge of rust-lang#114024 - matthiaskrgr:rollup-uhdbq64, r=matth…
fc8a3e3 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#113969 (add dynamic for smir)
 - rust-lang#113985 (Use erased self type when autoderefing for trait error suggestion)
 - rust-lang#113987 (Comment stuff in the new solver)
 - rust-lang#113992 (arm-none fixups)
 - rust-lang#113993 (Optimize format usage)
 - rust-lang#113994 (Optimize format usage)
 - rust-lang#114006 (Update sparc-unknown-none-elf platform README)
 - rust-lang#114021 (Add missing documentation for `Session::time`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2660d5d into rust-lang:master Jul 24, 2023
11 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Jul 24, 2023
@compiler-errors compiler-errors deleted the comments branch August 11, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
4 participants
@compiler-errors @rustbot @bors @lcnr