-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update x64 Linux host compiler to LLVM 17 #114297
Conversation
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit 40fd427833af056b248d3de730ba41b02960dc79 with merge 79e8cd82e9ff942bc98ff349bba41b89bba6fd5e... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
Huh. So either by switching the repo LLVM to 17 fixed the issue, or the |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit c5ded39504c39cf4cf3f0a4fd9ce987dd52181f2 with merge 846ecf69b7aff4f2f16616d28667d35c12c70aff... |
☀️ Try build successful - checks-actions |
1 similar comment
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
@bors try @rust-timer queue Trying to use our own built |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit 9cabc91 with merge 217c2852279cd1c70e4963b8d9b0d6464a64c3f8... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (217c2852279cd1c70e4963b8d9b0d6464a64c3f8): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 635.819s -> 633.222s (-0.41%) |
The verifier failure should be fixed in rc3, let's see if anything else turns up... @bors r+ rollup=never |
⌛ Testing commit 9cabc91 with merge d795c09554f79c77a76e0981f92436186203ae9d... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
@bors retry Looks spurious. |
☀️ Test successful - checks-actions |
@nikic Thanks for pushing this through! |
Finished benchmarking commit (0b31792): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 631.241s -> 629.756s (-0.24%) |
Use the correct `llvm-profdata` binary in `opt-dist` Turns out that we were probably using the wrong `llvm-profdata` binary in the PGO script all along. This should resolve the performance regressions of switching the host LLVM to 17 ([host `llvm-profdata`](rust-lang/rust#114297 (comment)), [target `llvm-profdata`](rust-lang/rust#114297 (comment))]). r? `@nikic`
Use the correct `llvm-profdata` binary in `opt-dist` Turns out that we were probably using the wrong `llvm-profdata` binary in the PGO script all along. This should resolve the performance regressions of switching the host LLVM to 17 ([host `llvm-profdata`](rust-lang/rust#114297 (comment)), [target `llvm-profdata`](rust-lang/rust#114297 (comment))]). r? `@nikic`
This PR updates the LLVM host compiler on 64-bit Linux to version 17.
r? @ghost