Rollup of 9 pull requests #114585
Merged
Rollup of 9 pull requests #114585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional changes intended. Adapts llvm-wrapper for llvm/llvm-project@65e57bb. Found by our experimental rust + llvm @ HEAD CI: https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/21304#0189c526-86cd-4db9-bdbc-dd0132dfc22b/197-500
…em-2, r=b-naber Fix spurious test failure with `panic=abort` Description on why it happens and why the fix should work is in the code comments.
Bubble up nested goals from equation in `predicates_for_object_candidate` This used to be needed for rust-lang#114036 (comment), but since it's no longer, I'm opening this as a separate PR. This also fixes one ICEing UI test: (`tests/ui/unboxed-closures/issue-53448.rs`) r? `@lcnr`
Add trait decls to SMIR r? `@oli-obk` Closes rust-lang/project-stable-mir#20
Set max_atomic_width for AVR to 16 This is currently set to 0 https://github.com/rust-lang/rust/blob/90f0b24ad3e7fc0dc0e419c9da30d74629cd5736/compiler/rustc_target/src/spec/avr_gnu_base.rs#L26-L27 However, LLVM supports {8,16}-bit atomic load/store on AVR (support for RMW is still quite incomplete and only partially supported). https://github.com/llvm/llvm-project/blob/llvmorg-15.0.0/llvm/test/CodeGen/AVR/atomics/load8.ll#L5-L13 https://github.com/llvm/llvm-project/blob/llvmorg-15.0.0/llvm/test/CodeGen/AVR/atomics/load16.ll#L3-L12 https://github.com/llvm/llvm-project/blob/llvmorg-15.0.0/llvm/test/CodeGen/AVR/atomics/store.ll#L3-L22 cc rust-lang#99668 r? `@Amanieu`
Set max_atomic_width for sparc-unknown-linux-gnu to 32 This is currently set to 64 https://github.com/rust-lang/rust/blob/90f0b24ad3e7fc0dc0e419c9da30d74629cd5736/compiler/rustc_target/src/spec/sparc_unknown_linux_gnu.rs#L8 However, AFAIK, this architecture doesn't support 64-bit atomics, and LLVM generates libcalls: https://godbolt.org/z/chzThWGG1 (Currently, attempts to run `cargo test` for this target result in "undefined reference to `__sync_val_compare_and_swap_8'" error. taiki-e/rust-cross-toolchain@02efe1e) r? `@Amanieu`
llvm-wrapper: adapt for LLVM API changes No functional changes intended. Adapts llvm-wrapper for llvm/llvm-project@65e57bb. Found by our experimental rust + llvm @ HEAD CI: https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/21304#0189c526-86cd-4db9-bdbc-dd0132dfc22b/197-500
stabilize abi_thiscall Closes rust-lang#42202, stabilizing the use of the "thiscall" ABI. FCP was substituted by a poll, and the poll has been accepted.
[miri][typo] Fix a typo in a vector_block comment.
…-obk CI: do not hide error logs in a group This PR avoids creating a GHA group at the very end of a CI workflow when some failure has happened. Before, when a failure has happened, its GHA group was not closed, however the clock drift check function would create a new group, which would actually close the group containing the error log, thus making errors hidden by default, which is not ideal. See discussion here: https://rust-lang.zulipchat.com/#narrow/stream/326414-t-infra.2Fbootstrap/topic/GHA.20groups.20being.20closed.20on.20failures r? bootstrap
rustbot
added
A-testsuite
|
@bors r+ rollup=never p=9 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 84ec2633de In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
falcucci
added a commit
to falcucci/changelog-it
that referenced
this pull request
Aug 7, 2023
adds the list of contributors to the template. the contributors are: enselic, ralfjung, trolldemorted, matthiaskrgr, ttsugriy, kobzol, and lnicola. this commit updates `example.md` by adding the contributors to the list. the changes can be seen in the diff: ```diff diff --git a/templates/example.md b/templates/example.md index a12803718a3e..da0ecc84c0c6 100644 --- a/templates/example.md +++ b/templates/example.md @@ -10,3 +10,16 @@ - [ci: do not hide error logs in a group](rust-lang/rust#114573) - [:arrow_up: `rust-analyzer`](rust-lang/rust#114576) - [rollup of 9 pull requests](rust-lang/rust#114585) + +### contributors + +- [enselic](https://github.com/enselic) +- [enselic](https://github.com/enselic) +- [ralfjung](https://github.com/ralfjung) +- [trolldemorted](https://github.com/trolldemorted) +- [matthiaskrgr](https://github.com/matthiaskrgr) +- [matthiaskrgr](https://github.com/matthiaskrgr) +- [ttsugriy](https://github.com/ttsugriy) +- [kobzol](https://github.com/kobzol) +- [lnicola](https://github.com/lnicola) +- [matthiaskrgr](https://github.com/matthiaskrgr) ```
|
Finished benchmarking commit (63a81b0): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 650.87s -> 651.258s (0.06%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
panic=abort#113568 (Fix spurious test failure withpanic=abort)predicates_for_object_candidate#114196 (Bubble up nested goals from equation inpredicates_for_object_candidate)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup