Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use smaller machines in PR runs #114625

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Aug 8, 2023

mingw-check job-linux-16c -> job-linux-4c
~job-linux-4c 20 min in auto job
~job-linux-16c 13 min in pr job
with current pr regressed to almost 21 min, it's ok.

mingw-check-tidy job-linux-16c -> job-linux-4c small enough, so reduce to minimal
~ job-linux-16c 3 min
with current pr regressed to almost 5 min, it's ok.

x86_64-gnu-tools job-linux-16c this is top job by time in PR, so don't touch it
~ job-linux-8c 1.30 hour in auto job
~ job-linux-16c 1 hour in pr job (affected by #114613, actual time ~ 30 min)

x86_64-gnu-llvm-15 job-linux-16c don't change too
~ job-linux-8c 1.30 hour in auto job
~ job-linux-16c 30 min in pr job

Noticed while working on #114621, so current time affected by always rebuilded docker images (but pr images always rebuilded before too, so nvm)

@klensy klensy changed the title CI:use smaller machines in PR runs CI: use smaller machines in PR runs Aug 8, 2023
@rustbot
Copy link
Collaborator

rustbot commented Aug 8, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 8, 2023
@klensy
Copy link
Contributor Author

klensy commented Aug 10, 2023

@rustbot ready

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

Let's try it!

@bors
Copy link
Contributor

bors commented Aug 13, 2023

📌 Commit 524572d has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2023
@klensy
Copy link
Contributor Author

klensy commented Aug 13, 2023

Current time distribution more like:
CI / PR - mingw-check (pull_request) Successful in 11m
CI / PR - mingw-check-tidy (pull_request) Successful in 3m
CI / PR - x86_64-gnu-llvm-15 (pull_request) Successful in 30m
CI / PR - x86_64-gnu-tools (pull_request) Successful in 24m
so time in topic slightly wrong.

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 13, 2023
…llaumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#94667 (Add `Iterator::map_windows`)
 - rust-lang#114069 (Allow using external builds of the compiler-rt profile lib)
 - rust-lang#114354 (coverage: Store BCB counter info externally, not directly in the BCB graph)
 - rust-lang#114625 (CI: use smaller machines in PR runs)
 - rust-lang#114777 (Migrate GUI colors test to original CSS color format)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d868276 into rust-lang:master Aug 13, 2023
11 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Aug 13, 2023
@klensy
Copy link
Contributor Author

klensy commented Aug 14, 2023

Now this:
CI / PR - mingw-check (pull_request) Successful in 19m
CI / PR - mingw-check-tidy (pull_request) Successful in 4m
CI / PR - x86_64-gnu-llvm-15 (pull_request) Successful in 30m
CI / PR - x86_64-gnu-tools (pull_request) Successful in 24m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants