-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove apple-alt dist build. #115029
Remove apple-alt dist build. #115029
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
Just to compare the configure settings, the alt build differs by: -build.sanitizers := True
-rust.codegen-backends := ['llvm']
-rust.lld := True
-rust.llvm-tools := True
-rust.lto := thin none of which seem particularly important. |
This makes sense to me, good find. I think given current goals around optimizing capacity, I'm inclined to remove as well, we might restore with re-enabled assertions later (with faster macos builders or something else). @bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (c60ff10): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 635.074s -> 636.639s (0.25%) |
This removes the dist-x86_64-apple-alt build to reduce CI usage because I suspect nobody is using it. This builder is almost identical to the
dist-x86_64-apple
with the small difference that the latter addsrust.lto=thin
, and I do not think that difference was intentional. The reason they are identical is because llvm assertions were disabled in #44610, but I did not see any discussion about the consequence that this made the alt build identical to the normal build. Perhaps because #44610 was intended to be temporary?