Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CFI: f32 and f64 are encoded incorrectly for cross-language CFI #115151

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Fix CFI: f32 and f64 are encoded incorrectly for cross-language CFI #115151

merged 1 commit into from
Aug 25, 2023

Commits on Aug 25, 2023

  1. Fix CFI: f32 and f64 are encoded incorrectly for c 

    Fix rust-lang#115150 by encoding f32 and f64 correctly for cross-language CFI. I
missed changing the encoding for f32 and f64 when I introduced the
integer normalization option in rust-lang#105452 as integer normalization does
not include floating point. `f32` and `f64` should be always encoded as
`f` and `d` since they are both FFI safe when their representation are
the same (i.e., IEEE 754) for both the Rust compiler and Clang.
    @rcvalle
    rcvalle committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    5d6e2d7 View commit details
    Browse the repository at this point in the history