Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rustc_on_unimplemented std-agnostic for alloc::rc #115210

Merged
merged 1 commit into from
Aug 26, 2023
Merged

Make rustc_on_unimplemented std-agnostic for alloc::rc #115210

merged 1 commit into from
Aug 26, 2023

Conversation

DogPawHat
Copy link
Contributor

See #112923

Just a few lines related to alloc:rc for Send and Sync.

That seems to be all of the ... = "std::..." issues found, but there a few notes with std:: inside them still.

r? @WaffleLapkin

@rustbot
Copy link
Collaborator

rustbot commented Aug 25, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @WaffleLapkin (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 25, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
WaffleLapkin
WaffleLapkin approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@WaffleLapkin WaffleLapkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you squash the commits together?

@WaffleLapkin
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 25, 2023
@DogPawHat DogPawHat force-pushed the std-agnostic-rustc_on_unimplemented-for-alloc-rc branch from e1217e6 to 6ec570a Compare August 25, 2023 23:53
@DogPawHat
Copy link
Contributor Author

Squashed

@DogPawHat
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 26, 2023
@WaffleLapkin
Copy link
Member

Thanks! @bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 26, 2023

📌 Commit 6ec570a has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 26, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 26, 2023
@bors
Auto merge of rust-lang#115246 - matthiaskrgr:rollup-zdiw9gt, r=matth…
7646ece 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#115197 (Remove special cases that are no longer needed due to rust-lang#112606)
 - rust-lang#115210 (Make `rustc_on_unimplemented` std-agnostic for `alloc::rc`)
 - rust-lang#115237 (Fixup sparc-unknown-none-elf table spacing)
 - rust-lang#115244 (Migrate GUI colors test to original CSS color format)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c3668d3 into rust-lang:master Aug 26, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Aug 26, 2023
@dtolnay dtolnay mentioned this pull request Aug 28, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 28, 2023
@matthiaskrgr
Rollup merge of rust-lang#115311 - dtolnay:usearcself, r=compiler-errors
9b0abe3 
Revert "Suggest using `Arc` on `!Send`/`!Sync` types"

Closes rust-lang#114687. This is a clean revert of rust-lang#88936 + rust-lang#115210. The suggestion to Arc\<{Self}\> when Self does not implement Send is *always* wrong.

rust-lang#114842 is considering a way to make a more refined suggestion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WaffleLapkin WaffleLapkin WaffleLapkin approved these changes

Assignees

@WaffleLapkin WaffleLapkin

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
5 participants
@DogPawHat @rustbot @rust-log-analyzer @WaffleLapkin @bors